Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1468 pyembed docs #1784

Merged
merged 12 commits into from
May 7, 2021
Merged

Conversation

DanielAdriaansen
Copy link
Contributor

@DanielAdriaansen DanielAdriaansen commented May 7, 2021

Closes #1468

Pull Request Testing

  • Describe testing already performed for these changes:

    Made changes locally and reviewed on RTD here:
    https://met.readthedocs.io/en/feature_1468_pyembed_docs/Users_Guide/appendixF.html

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Please review the documentation here: https://met.readthedocs.io/en/feature_1468_pyembed_docs/Users_Guide/appendixF.html

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    Yes

  • Do these changes include sufficient testing updates? [Yes or No]
    N/A

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    I don't think so.

  • Please complete this pull request review by 5/7/2021.

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@DanielAdriaansen DanielAdriaansen added the component: documentation Documentation issue label May 7, 2021
@DanielAdriaansen DanielAdriaansen added this to the MET 10.0.0 milestone May 7, 2021
@DanielAdriaansen DanielAdriaansen changed the base branch from main_v9.1 to develop May 7, 2021 20:32
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me. Thanks Dan. I approve.

@DanielAdriaansen DanielAdriaansen merged commit 649a51b into develop May 7, 2021
@DanielAdriaansen DanielAdriaansen deleted the feature_1468_pyembed_docs branch May 7, 2021 20:35
@JohnHalleyGotway JohnHalleyGotway removed the component: documentation Documentation issue label May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation for Xarray Python embedding
2 participants