Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 1795 fortify_nccf #1802

Merged
merged 4 commits into from
May 21, 2021
Merged

Bugfix 1795 fortify_nccf #1802

merged 4 commits into from
May 21, 2021

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented May 20, 2021

Pull Request Testing

  • Describe testing already performed for these changes:

    Check the Fortify output

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    None

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Run Fortify enabled build and check the logs

@hsoh-u hsoh-u added this to the MET 10.1.0 milestone May 20, 2021
@hsoh-u
Copy link
Collaborator Author

hsoh-u commented May 20, 2021

I will modify renderinfo.cc, too

@hsoh-u
Copy link
Collaborator Author

hsoh-u commented May 20, 2021

Found another memory leak at setup() (rmw_analysis.cc).

  • allocate DataCubes for 2D and 3D
  • Save only 2D or 3D DataCubes and free them later

@JohnHalleyGotway JohnHalleyGotway linked an issue May 21, 2021 that may be closed by this pull request
21 tasks
@JohnHalleyGotway JohnHalleyGotway changed the title #1795 fortify NCCF release memory Bugfix 1795 fortify_nccf May 21, 2021
@JohnHalleyGotway
Copy link
Collaborator

Note that I updated the "Linked issues" section of this PR to link back to the original issue #1795.
I also renamed the title of this PR to match the conventions specified in the issue template.

Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I visually inspected these code changes and they make sense to me. I approve of these changes.

I look forward to us getting GitHub actions set up to automatically run a full regression test for all pull requests. That's my only concern is the potential for unintended consequences of these code changes. But based on these changes, that looks unlikely.

@hsoh-u hsoh-u merged commit 3cb3f0e into develop May 21, 2021
@hsoh-u hsoh-u deleted the bugfix_1795_fortify_nccf branch September 1, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Fortify High finding for src/libcode/vx_data2d_nccf/nccf_file.cc : 346
2 participants