Update develop-ref after #1812

.github/ISSUE_TEMPLATE/bug_report.md

@@ -48,8 +48,9 @@ Describe the steps to reproduce the behavior:
 - [ ] Select **requestor(s)**
 
 ### Projects and Milestone ###
-- [ ] Review **projects** and select relevant **Repository** and **Organization** ones or add "alert:NEED PROJECT ASSIGNMENT" label
-- [ ] Select **milestone** to relevant bugfix version
+- [ ] Select **Organization** level **Project** for support of the current coordinated release
+- [ ] Select **Repository** level **Project** for development toward the next official release or add **alert: NEED PROJECT ASSIGNMENT** label
+- [ ] Select **Milestone** as the next bugfix version
 
 ## Define Related Issue(s) ##
 Consider the impact to the other METplus components.
@@ -68,10 +69,15 @@ Branch name: `bugfix_<Issue Number>_main_<Version>_<Description>`
 - [ ] Submit a pull request to merge into **main_\<Version>**.
 Pull request: `bugfix <Issue Number> main_<Version> <Description>`
 - [ ] Define the pull request metadata, as permissions allow.
-Select: **Reviewer(s)**, **Project(s)**, **Milestone**, and **Linked issues**
+Select: **Reviewer(s)** and **Linked issues**
+Select: **Organization** level software support **Project** for the current coordinated release
+Select: **Milestone** as the next bugfix version
 - [ ] Iterate until the reviewer(s) accept and merge your changes.
 - [ ] Delete your fork or branch.
 - [ ] Complete the steps above to fix the bug on the **develop** branch.
 Branch name:  `bugfix_<Issue Number>_develop_<Description>`
 Pull request: `bugfix <Issue Number> develop <Description>`
+Select: **Reviewer(s)** and **Linked issues**
+Select: **Repository** level development cycle **Project** for the next official release
+Select: **Milestone** as the next official version
 - [ ] Close this issue.

.github/ISSUE_TEMPLATE/enhancement_request.md

@@ -38,8 +38,8 @@ Consider breaking the enhancement down into sub-issues.
 - [ ] Select **requestor(s)**
 
 ### Projects and Milestone ###
-- [ ] Review **projects** and select relevant **Repository** and **Organization** ones or add "alert:NEED PROJECT ASSIGNMENT" label
-- [ ] Select **milestone** to next major version milestone or "Future Versions"
+- [ ] Select **Repository** and/or **Organization** level **Project(s)** or add **alert: NEED PROJECT ASSIGNMENT** label
+- [ ] Select **Milestone** as the next official version or **Future Versions**
 
 ## Define Related Issue(s) ##
 Consider the impact to the other METplus components.
@@ -58,7 +58,9 @@ Branch name: `feature_<Issue Number>_<Description>`
 - [ ] Submit a pull request to merge into **develop**.
 Pull request: `feature <Issue Number> <Description>`
 - [ ] Define the pull request metadata, as permissions allow.
-Select: **Reviewer(s)**, **Project(s)**, **Milestone**, and **Linked issues**
+Select: **Reviewer(s)** and **Linked issues**
+Select: **Repository** level development cycle **Project** for the next official release
+Select: **Milestone** as the next official version
 - [ ] Iterate until the reviewer(s) accept and merge your changes.
 - [ ] Delete your fork or branch.
 - [ ] Close this issue.

.github/ISSUE_TEMPLATE/new_feature_request.md

@@ -42,8 +42,8 @@ Consider breaking the new feature down into sub-issues.
 - [ ] Select **requestor(s)**
 
 ### Projects and Milestone ###
-- [ ] Review **projects** and select relevant **Repository** and **Organization** ones or add "alert:NEED PROJECT ASSIGNMENT" label
-- [ ] Select **milestone** to next major version milestone or "Future Versions"
+- [ ] Select **Repository** and/or **Organization** level **Project(s)** or add **alert: NEED PROJECT ASSIGNMENT** label
+- [ ] Select **Milestone** as the next official version or **Future Versions**
 
 ## Define Related Issue(s) ##
 Consider the impact to the other METplus components.
@@ -62,7 +62,9 @@ Branch name: `feature_<Issue Number>_<Description>`
 - [ ] Submit a pull request to merge into **develop**.
 Pull request: `feature <Issue Number> <Description>`
 - [ ] Define the pull request metadata, as permissions allow.
-Select: **Reviewer(s)**, **Project(s)**, **Milestone**, and **Linked issues**
+Select: **Reviewer(s)** and **Linked issues**
+Select: **Repository** level development cycle **Project** for the next official release
+Select: **Milestone** as the next official version
 - [ ] Iterate until the reviewer(s) accept and merge your changes.
 - [ ] Delete your fork or branch.
 - [ ] Close this issue.

.github/ISSUE_TEMPLATE/sub-issue.md

@@ -28,5 +28,5 @@ This is a sub-issue of #*List the parent issue number here*.
 - [ ] Select **requestor(s)**
 
 ### Projects and Milestone ###
-- [ ] Review **projects** and select relevant **Repository** and **Organization** ones or add "alert:NEED PROJECT ASSIGNMENT" label
-- [ ] Select **milestone** to next major version milestone or "Future Versions"
+- [ ] Select **Repository** and/or **Organization** level **Project(s)** or add **alert: NEED PROJECT ASSIGNMENT** label
+- [ ] Select **Milestone** as the next official version or **Future Versions**

.github/ISSUE_TEMPLATE/task.md

@@ -38,8 +38,8 @@ Consider breaking the task down into sub-issues.
 - [ ] Select **requestor(s)**
 
 ### Projects and Milestone ###
-- [ ] Review **projects** and select relevant **Repository** and **Organization** ones or add "alert:NEED PROJECT ASSIGNMENT" label
-- [ ] Select **milestone** to next major version milestone or "Future Versions"
+- [ ] Select **Repository** and/or **Organization** level **Project(s)** or add **alert: NEED PROJECT ASSIGNMENT** label
+- [ ] Select **Milestone** as the next official version or **Future Versions**
 
 ## Define Related Issue(s) ##
 Consider the impact to the other METplus components.
@@ -58,7 +58,9 @@ Branch name: `feature_<Issue Number>_<Description>`
 - [ ] Submit a pull request to merge into **develop**.
 Pull request: `feature <Issue Number> <Description>`
 - [ ] Define the pull request metadata, as permissions allow.
-Select: **Reviewer(s)**, **Project(s)**, **Milestone**, and **Linked issues**
+Select: **Reviewer(s)** and **Linked issues**
+Select: **Repository** level development cycle **Project** for the next official release
+Select: **Milestone** as the next official version
 - [ ] Iterate until the reviewer(s) accept and merge your changes.
 - [ ] Delete your fork or branch.
 - [ ] Close this issue.

.github/pull_request_template.md

@@ -11,12 +11,16 @@
 - [ ] Will this PR result in changes to the test suite? **[Yes or No]**</br>
 If **yes**, describe the new output and/or changes to the existing output:</br>
 
+- [ ] Please complete this pull request review by **[Fill in date]**.</br>
+
 ## Pull Request Checklist ##
 See the [METplus Workflow](https://dtcenter.github.io/METplus/Contributors_Guide/github_workflow.html) for details.
 - [ ] Complete the PR definition above.
 - [ ] Ensure the PR title matches the feature or bugfix branch name.
 - [ ] Define the PR metadata, as permissions allow.
-Select: **Reviewer(s)**, **Project(s)**, and **Milestone**
-- [ ] After submitting the PR, select **Linked Issues** with the original issue number.
+Select: **Reviewer(s)**
+Select: **Organization** level software support **Project** or **Repository** level development cycle **Project**
+Select: **Milestone** as the version that will include these changes
+- [ ] After submitting the PR, select **Linked issues** with the original issue number.
 - [ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
 - [ ] Close the linked issue and delete your feature or bugfix branch from GitHub.

README.md

@@ -2,4 +2,4 @@
 
 This repository contains the source code for the Model Evaluation Tools package (met), unit test code (test), and scripts used to build and test the code (scripts).
 
-Please see the MET website (https://dtcenter.org/community-code/model-evaluation-tools-met) and direct questions to met_help@ucar.edu.
+Please see the [MET website](https://dtcenter.org/community-code/model-evaluation-tools-met) for more information. Support	for the	METplus	components is provided through the [METplus Discussions](https://github.com/dtcenter/METplus/discussions) forum.  Users are welcome and encouraged to answer or address each other's questions there!  For more information, please read "[Welcome to the METplus Components Discussions](https://github.com/dtcenter/METplus/discussions/939)".

met/README

@@ -20,8 +20,8 @@ This is the main directory for the Model Evaluation Tools source code release.
 ================================================================================
 
 For questions, please:
-- Refer to the MET User's Guide in the /doc sub-directory.
-- Refer to the MET website: http://www.dtcenter.org/met/users
+- Refer to the MET User's Guide: https://met.readthedocs.io/en/latest
+- Refer to the MET website: http://dtcenter.org/community-code/model-evaluation-tools-met
 - Send mail to met_help@ucar.edu.
 
 Dependencies
@@ -52,7 +52,7 @@ Dependencies
 
 - It is suggested that the following tools be used in conjunction with MET:
    - Unified Post-Processor
-      - http://www.dtcenter.org/wrf-nmm/users
+      - http://dtcenter.org/community-code/unified-post-processor-upp
 
 NOTE: The required libraries should be compiled with the same set of compilers
       to be used in compiling MET.
@@ -63,7 +63,7 @@ How to compile and run?
 For more detailed instructions on building MET and for a list of supported
 platforms and compilers, please refer to the MET User's Guide in the doc/
 sub-directory, or the MET Online Tutorial:
-  http://www.dtcenter.org/met/users/support/online_tutorial
+  http://dtcenter.org/community-code/model-evaluation-tools-met/online-tutorial
 
 - Set the $CXX and $F77 environment variables to specify the C++ and FORTRAN
   compilers to be used.  If not set, configure will search for compilers and the

met/configure.ac

@@ -2,7 +2,7 @@
 # Process this file with autoconf to produce a configure script.
 
 AC_PREREQ([2.69])
-AC_INIT([MET], [m4_esyscmd_s(echo ${MET_BUILD_VERSION:-8.1})], [met_help@ucar.edu], [], [http://www.dtcenter.org/met/users])
+AC_INIT([MET], [m4_esyscmd_s(echo ${MET_BUILD_VERSION:-development})], [met_help@ucar.edu], [], [http://dtcenter.org/community-code/model-evaluation-tools-met])
 AC_CONFIG_SRCDIR([src/tools/tc_utils/tc_dland/tc_dland.cc])
 AC_CONFIG_HEADERS([config.h])
 
@@ -1041,11 +1041,14 @@ CPPFLAGS=$CPPFLAGS' -DMET_BASE="\"$(pkgdatadir)\""'
 
 AC_SUBST(FC_LIBS, [-lgfortran])
 
-# The CXXFLAGS default to "-O2 -g".  The optimization is causing
-# problems so just set it to "-g" if the user hasn't overridden it
-# themselves.
+# For GNU compilers, CFLAGS, CXXFLAGS, and FFLAGS default to "-O2 -g".
+# The CXXFLAGS "-O2" optimization has caused problems in the past.
+# For Intel compilers, "-g" slows down runtimes considerably (MET #1778).
+# For development, retain the "-g" option. Otherwise, discard it.
 
-: ${CXXFLAGS="-g"}
+AM_COND_IF([ENABLE_DEVELOPMENT], [: ${CFLAGS="-g -O2"}], [: ${CFLAGS="-O2"}])
+AM_COND_IF([ENABLE_DEVELOPMENT], [: ${CXXFLAGS="-g"}  ], [: ${CXXFLAGS=""}] )
+AM_COND_IF([ENABLE_DEVELOPMENT], [: ${FFLAGS="-g -O2"}], [: ${FFLAGS="-O2"}])
 
 # Checks for programs.
 

met/data/wrappers/read_tmp_dataplane.py

@@ -17,14 +17,19 @@
 ds = nc.Dataset(netcdf_filename, 'r')
 met_data = ds['met_data'][:]
 met_attrs = {}
+
+# grid is defined as a dictionary or string
 grid = {}
 for attr, attr_val in ds.__dict__.items():
-    if 'grid' in attr:
+    if 'grid.' in attr:
         grid_attr = attr.split('.')[1]
         grid[grid_attr] = attr_val
     else:
         met_attrs[attr] = attr_val
-met_attrs['grid'] = grid
+
+if grid:
+    met_attrs['grid'] = grid
+
 met_attrs['name'] = met_attrs['name_str']
 del met_attrs['name_str']
 met_info['met_data'] = met_data