Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 1508 tc_gen file list parsing #1841

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Jun 23, 2021

Pull Request Testing

  • Describe testing already performed for these changes:

Ran unit tests and compare the outputs of ensemble_stat and tc_gen

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

The nightly builds failed with tc_gen. We can confirm with the nightly builds.
No idea for testing except making sure nothing is changed at the output from MET apps.

  • run unit tests (ascii2nc ensemble_stat tc_gen)

  • compare the the output of ensemble_stat and tc_gen

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u added this to the MET 10.1.0 milestone Jun 23, 2021
@hsoh-u hsoh-u linked an issue Jun 23, 2021 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the unit tests for ascii2nc, ensemble_stat, and tc_gen, and compared the the output of ensemble_stat and tc_gen with the unit test output from develop and saw that there were no differences as expected. I approve this pull request.

@jprestop jprestop removed the request for review from JohnHalleyGotway June 23, 2021 19:35
@hsoh-u hsoh-u merged commit d2bad01 into develop Jun 24, 2021
@hsoh-u hsoh-u deleted the bugfix_1508_tc_gen_file_list_parsing branch September 1, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File list parsing logic continues to fail in the Nightly Build for tc_gen.
2 participants