Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main_v10.0-ref after #1837. #1847

Merged
merged 15 commits into from
Jul 6, 2021
Merged

Update main_v10.0-ref after #1837. #1847

merged 15 commits into from
Jul 6, 2021

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Jul 6, 2021 •
edited
Loading

Pull Request Testing

Update main_v10.0-ref after PR #1837 for issue #1817. This bugfix corrects point2grid output which modifies/corrects output in produced by the unit tests in the develop branch.

  • Describe testing already performed for these changes:

    The NB for main_v10.0 failed on 20210706 with the modified output.
    kiowa:/d1/projects/MET/MET_regression/main_v10.0/NB20210706/test_regression_20210706.log
COMPARING point2grid/point2grid_2D_time_west_bering_sea.nc
file1: MET-main_v10.0-ref/test_output/point2grid/point2grid_2D_time_west_bering_sea.nc
file2: MET-main_v10.0/test_output/point2grid/point2grid_2D_time_west_bering_sea.nc
ERROR: found  5421 differences in var brightness_temperature_4micron         - max abs: 26.39667

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    No additional testing needed.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
    This PR serves as documentation of the change.

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

    As described above.

  • Please complete this pull request review by [07/06/21].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

JohnHalleyGotway and others added 15 commits May 12, 2021 11:28
@JohnHalleyGotway
Per #1789, remove duplicate plot_point_obs configuration section. (#1790
3becf7e 
)
@JohnHalleyGotway
Per #1798, fix up the read_tmpe_dataplane.py script to handle a grid …
cba7377 
…string or dictionary. (#1799)
@bikegeek
Github Issue #1801: Comment out code that checks for BEST track to su…
de18798 
…pport extra-tropical cyclone tracks not verified against BEST tracks.
@jprestop
Bugfix 1395 main_v10.0 comp script (#1796)
4984596 
* Updating compile script and associated config files for met-10.0.0

* Removing old config files

* install_met_env.het

* Updated orion file

* Added stampede2 config file

* Adding modulefiles for various machines
@bikegeek
Merge pull request #1805 from dtcenter/task_1801_plot_tcmpr
e7b3bcd 
Bugfix 1801 main_v10.0 plot_tcmpr
@JohnHalleyGotway
Feature main_v10.0 bugfix_checklist (#1803)
d7f1b58 
* Recommended updates to clarify the use of projects and milestones for bugfixes.

* Making details consistent across all issue templates.
@JohnHalleyGotway
Per met-help question (https://rt.rap.ucar.edu/rt/Ticket/Display.html…
ebb64f6 
…?id=99964) clarify the description of the obs_thresh option.
@jprestop
Update README.md
9cb68d2 
Adding text for GitHub Discussions
@georgemccabe
changed non-unicode apostrophe and fixed typo in URL (#1813)
97bc695
@JohnHalleyGotway
Correct formatting errors in release notes.
0c79e00
#1817 Added to_north argument at two_to_one()
d747c73
#1817 Calls two_to_one() with false for the third argument, if latitu…
93e0c07 
…de moves north to south
@hsoh-u
Merge pull request #1837 from dtcenter/bugfix_1817_MET_v10.0_point2gr…
b73243c 
…id_latlon_to_laton

Bugfix 1817 met v10.0 point2grid latlon to laton
#1508 checking stat() methoid returns no error before looking at FILE…
16a3695 
… flag
@hsoh-u
Merge pull request #1842 from dtcenter/bugfix_1508_met_v10.0_tc_gen_f…
6410580 
…ile_list_parsing

Bugfix 1508 met_v10.0 tc_gen file list parsing
@JohnHalleyGotway JohnHalleyGotway added this to the met-10.0.1 (bugfix) milestone Jul 6, 2021
jprestop
jprestop approved these changes Jul 6, 2021
View reviewed changes
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this PR serves as documentation of the change and that no additional testing is necessary. I approve this request.

@JohnHalleyGotway JohnHalleyGotway linked an issue Jul 6, 2021 that may be closed by this pull request
The output of point2grid is flipped and rotated with lat/lon to lat/lon conversion #1817
Closed
22 tasks
@JohnHalleyGotway JohnHalleyGotway merged commit 70bf06b into main_v10.0-ref Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprestop jprestop jprestop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MET 10.0.1 (bugfix)
Development

Successfully merging this pull request may close these issues.

The output of point2grid is flipped and rotated with lat/lon to lat/lon conversion
5 participants
@JohnHalleyGotway @jprestop @bikegeek @georgemccabe @hsoh-u