Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 1838 point2grid supports the double type lat/lon #1848

Merged
merged 3 commits into from
Jul 8, 2021

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Jul 7, 2021

Pull Request Testing

The NCCF library reads lat/lon variables as float. The NetCDF API does not read the double type variable if the float type data is requested. The NetCDF API reads the double type values and converts them to float type.

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

/d1/personal/hsoh/git/bugfixes/bugfix_1838_point2grid_support_double_type_lat_lon/MET/met/bin/point2grid \
/d1/personal/hsoh/data/Binyu/wrong_latitude_units/VOLCAT_HIMAWARI-8_FLDK_s2020296_050000_v300250_VCB_w167_FLDK_b2020295_204000_g001_pc_rg.nc \
"latlon 200 200 45 153 0.1 0.1" \
bezy_2020296_05_regrided_p2g.nc \
-field 'name="ash_mass_loading"; level="(0,*,*)";' \
-v 4
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [7/09/2021].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u added this to the MET 10.1.0 milestone Jul 7, 2021
@hsoh-u hsoh-u linked an issue Jul 7, 2021 that may be closed by this pull request
22 tasks
@hsoh-u hsoh-u changed the title Bugfix 1838 point2grid support double type lat lon Bugfix 1838 point2grid supports the double type lat/lon Jul 7, 2021
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes. Thanks for the sample testing command. I ran them using MET version 10.0.0 and the patched version. MET version 10.0.0 produces a field of empty output data while the patched version produces sane output.

@hsoh-u hsoh-u merged commit 73e9438 into develop Jul 8, 2021
@hsoh-u hsoh-u deleted the bugfix_1838_point2grid_support_double_type_lat_lon branch July 8, 2021 17:03
@hsoh-u hsoh-u restored the bugfix_1838_point2grid_support_double_type_lat_lon branch July 8, 2021 17:03
@hsoh-u hsoh-u deleted the bugfix_1838_point2grid_support_double_type_lat_lon branch September 1, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Point2Grid to support double type latitude/longitude variables
2 participants