Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1453 create pdf user guide #1871

Merged
merged 74 commits into from
Aug 6, 2021

Conversation

ksearight
Copy link
Contributor

@ksearight ksearight commented Aug 5, 2021

Pull Request Testing

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by August 31.

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@ksearight ksearight linked an issue Aug 5, 2021 that may be closed by this pull request
19 tasks
@ksearight
Copy link
Contributor Author

I've modified the settings to prevent the shifting of the ROC diagram past the section it is embedded in. I also merged in newer changes from develop and reconciled conflicts as well as replacing some UTF-8 characters (dashes).

Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes.

@ksearight ksearight merged commit 4e1c3ad into develop Aug 6, 2021
@ksearight ksearight deleted the feature_1453_create_pdf_user_guide branch August 6, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create and publish a PDF of the MET User's Guide via Read-The-Docs
2 participants