Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 1926 gridstat openmp #1977

Merged
merged 30 commits into from
Jan 13, 2022
Merged

Feature 1926 gridstat openmp #1977

merged 30 commits into from
Jan 13, 2022

Commits on Nov 18, 2021

  1. Feature 1926. Introduce OpenMP in GridStat.

    @mo-mglover
    mo-mglover committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    ed6934b View commit details
    Browse the repository at this point in the history

  2. Feature 1926. Add MET_OPENMP flag to automake setup.

    @mo-mglover
    mo-mglover committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    86c1a50 View commit details
    Browse the repository at this point in the history

  3. Feature 1926. Indentation tweaks.

    @mo-mglover
    mo-mglover committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    b3a063a View commit details
    Browse the repository at this point in the history

  4. Feature 1926. Revert temporary C++17 temporary file code tweak.

    @mo-mglover
    mo-mglover committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    e0257c6 View commit details
    Browse the repository at this point in the history

  5. Feature 1926. Add _OPENMP ifdef for omp.h.

    @mo-mglover
    mo-mglover committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    7d81d41 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Feature 1926. Revert tweak to CXX optimisation level with MET_DEVELOP… 

    …MENT.
    @mo-mglover
    mo-mglover committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    3ff12fe View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. Per #1926, switch the OpenMP configuration option from being like MET… 

    …_DEVELOPMENT to being like GRIB2, with --enable-grib2."
    @JohnHalleyGotway @mo-mglover
    JohnHalleyGotway authored and mo-mglover committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    9a045e0 View commit details
    Browse the repository at this point in the history

  2. Per #1926, just like --enable-grib2 and --enable-python, add a test p… 

    …laceholder for --enable-openmp so that running make test works.
    @JohnHalleyGotway @mo-mglover
    JohnHalleyGotway authored and mo-mglover committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    4c176c4 View commit details
    Browse the repository at this point in the history

  3. Feature #1926: Ensure OpenMP flag is passed to the linker. Revert to … 

    …_OPENMP for the moment.
    @mo-mglover
    mo-mglover committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    7043995 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. Feature #1926. Write thread count via logging, not cout. 

    Co-authored-by: johnhg <johnhg@ucar.edu>
    @mo-mglover @JohnHalleyGotway
    mo-mglover and JohnHalleyGotway committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    81c98b9 View commit details
    Browse the repository at this point in the history

  2. Feature #1926: Add note about --enable-openmp in installation.rst

    @mo-mglover
    mo-mglover committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    1abb2be View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. Per #1926, adding a call to Grid-Stat to run on 2 threads. This shoul… 

    …d produce the same result as the previous test named grid_stat_GRIB2_NAM_RTMA.
    @JohnHalleyGotway
    JohnHalleyGotway committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    d6969c6 View commit details
    Browse the repository at this point in the history

  2. Per #1926, updating GridStatConfig_rtma to switch width = 1 to 3. Thi… 

    …s seems like a pretty obvious typo that was causing a warning message to be written to the log file. While this will change the unit test results, I'm confident it was the original intention of this Grid-Stat configuration.
    @JohnHalleyGotway
    JohnHalleyGotway committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    2b37a69 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. Per #1926, tweak the openmp log message slightly.

    @JohnHalleyGotway
    JohnHalleyGotway committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    4b2982f View commit details
    Browse the repository at this point in the history

  2. Per #1926, switch from manual --enable-openmp support in autoconf to … 

    …calling the AC_OPENMP() macro. And that macro compile WITH openmp support by default. It can be disabled using --disable-openmp.
    @JohnHalleyGotway
    JohnHalleyGotway committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    3c1a5db View commit details
    Browse the repository at this point in the history

  3. Per #1926, after switching to the AC_OPENMP() macro, these changes to… 

    … scripts are no longer needed to enable make test to run.
    @JohnHalleyGotway
    JohnHalleyGotway committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    b595de4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into feature_1926_gridstat_openmp

    @JohnHalleyGotway
    JohnHalleyGotway committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    359d823 View commit details
    Browse the repository at this point in the history

  5. Per #1926, since openmp support will now be compiled by default, swit… 

    …ch the docs from explaining --enable-openmp to --disable-openmp.
    @JohnHalleyGotway
    JohnHalleyGotway committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    ecaa653 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Feature #1926. Use default(none) to force explicit private or `sh… 

    …ared`.
    @mo-mglover
    mo-mglover committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    9594505 View commit details
    Browse the repository at this point in the history

  2. Feature #1926: Default to single thread if OMP_NUM_THREADS is left un… 

    …set.
    @mo-mglover
    mo-mglover committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    e8d928b View commit details
    Browse the repository at this point in the history

  3. Feature #1926: Add OpenMP initialisation to other tools calling fract… 

    …ional_coverage.
    @mo-mglover
    mo-mglover committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    dd35aa4 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Update met/src/basic/vx_util/handle_openmp.cc 

    Co-authored-by: johnhg <johnhg@ucar.edu>
    @mo-mglover @JohnHalleyGotway
    mo-mglover and JohnHalleyGotway authored Dec 16, 2021
    Configuration menu
    Copy the full SHA
    e0d7840 View commit details
    Browse the repository at this point in the history

  2. Update met/src/basic/vx_util/Makefile.am 

    Co-authored-by: johnhg <johnhg@ucar.edu>
    @mo-mglover @JohnHalleyGotway
    mo-mglover and JohnHalleyGotway authored Dec 16, 2021
    Configuration menu
    Copy the full SHA
    78e4354 View commit details
    Browse the repository at this point in the history

  3. Feature #1926: Lengthen OMP_NUM_THREADS debug message, plus user guid… 

    …e info.
    @mo-mglover
    mo-mglover committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    b2a6c1e View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2021

  1. Set up the Runtime Environment Variables Section and started adding i… 

    …nfo from openmp.rst
    Julie Prestopnik committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    f39313d View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. Updated documenation and fixed typos

    Julie Prestopnik committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    63b1fce View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. removed openmp.rst in favor of having the information contained in a … 

    …Runtime Environment Variables section in config_options.rst and removed openmp from index.rst
    Julie Prestopnik committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    3e89e56 View commit details
    Browse the repository at this point in the history

  2. Fixed typo

    Julie Prestopnik committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    83688f5 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. Merge branch 'develop' into feature_1926_gridstat_openmp

    @JohnHalleyGotway
    JohnHalleyGotway committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    d73d537 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Merge branch 'develop' into feature_1926_gridstat_openmp

    @JohnHalleyGotway
    JohnHalleyGotway committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    821ca68 View commit details
    Browse the repository at this point in the history