Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop-ref after #1990, #1992, and #1994 #1995

Merged
merged 25 commits into from
Dec 14, 2021
Merged

Commits on Oct 26, 2021

  1. Per #1906, modify code to pass entire path to make_temp_file_name ins…

    …tead of only the filename so that the function can tell whether or not the file exists. (#1952)
    
    Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
    jprestop and Julie Prestopnik committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    9437447 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Feature 1761 percent thresh (#1956)

    * Per issue #1761 in set_perc() adding code to get FBIAS numeric value, like 1.0 or 0.9, etc. SL
    
    * Per issue #1761: in set_perc(), modified actual percentile calculation at end to use the extracted FBIAS numeric value (float). SL
    
    * Per issue #1761: modified the check on the perc_thresh_freq_bias, just has to be > 0 now. SL
    
    * Per issue #1761: cleaned up code in set_perc(). SL
    
    * Per #1761, updates to Simple_Node::set_perc() to handle variable frequency bias amounts.
    Changes include:
    - Reverting the formatting of this back to how it originally was in the develop branch. In general, just match the formatting of the existing file, so as the minimize the number of difference lines.
    - Add logic to adjust the percentile to be found based on the requested FBIAS value. Multiplying or dividing the percentile by the FBIAS value depends on the inequality type and whether we're bias adjusting the forecast or observation data.
    - Adjust the log messages slightly.
    
    Please be aware that I'm not totally confident in these changes. They warrant much more testing. This logic is very, very confusing.
    
    * Per #1761, call compute_percentile() when double-checking the percentile values.
    
    * Per #1761, remove unused variable.
    
    * Per #1761, add warning for percentiles > 100.
    
    * Per #1761. In set_perc(), after testing cleaned up code. SL
    
    * Per issue #1761: adding new config file for testing dynamic FBIAS values. SL
    
    * Per issue #1761: added new unit test for dynamic FBIAS values when running grid_stat. SL
    
    * Per issue #1761, modified FBIAS section to indicated that the user can use dynamic values that are not 1.0. SL
    
    * Update met/docs/Users_Guide/config_options.rst
    
    Co-authored-by: johnhg <johnhg@ucar.edu>
    
    * Update met/docs/Users_Guide/config_options.rst
    
    Co-authored-by: johnhg <johnhg@ucar.edu>
    
    * Update met/docs/Users_Guide/config_options.rst
    
    Co-authored-by: johnhg <johnhg@ucar.edu>
    
    * Update test/config/GridStatConfig_fbias_perc_thresh
    
    Co-authored-by: johnhg <johnhg@ucar.edu>
    
    * Update test/config/GridStatConfig_fbias_perc_thresh
    
    Co-authored-by: johnhg <johnhg@ucar.edu>
    
    * Update test/config/GridStatConfig_fbias_perc_thresh
    
    Co-authored-by: johnhg <johnhg@ucar.edu>
    
    * Update test/config/GridStatConfig_fbias_perc_thresh
    
    Co-authored-by: johnhg <johnhg@ucar.edu>
    
    * Per issue #1761, set nc_pairs_flag = FALSE. SL
    
    Co-authored-by: Seth Linden <linden@kiowa.rap.ucar.edu>
    Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
    3 people committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    8c446ff View commit details
    Browse the repository at this point in the history
  2. Feature 1905 ens_ctrl (#1955)

    Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
    JohnHalleyGotway and j-opatz committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    d60924c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3b13ce1 View commit details
    Browse the repository at this point in the history
  4. Per #1905, committing a hotfix directly to the develop branch. Revert…

    …ing the logic for computing the ensemble range back to what it was previously. The new version produced very slight differences in the 6-th or 7-th decimal place when compared to previous results. There's not good reason for these changes which were caused by the order of operations in casting from doubles to floats. Reverting back to the old logic prevents diffs for anyone else downstream and is the prudent choice.
    JohnHalleyGotway committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    5131042 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. Configuration menu
    Copy the full SHA
    4ff28d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Feature 1949 cf netcdf documentaton (#1951)

    * #1949 Added CF compliant NetCDF into data IO
    
    * #1949 Added commas
    
    * #1948 Some corrections for typo and added the links for CF attributes
    
    * #1948 Added Performance with NetCDF input data
    
    * #1949 Corrected tyoe and applied Juloie's suggestions
    
    Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu>
    hsoh-u and Howard Soh committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    aee6269 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    867360f View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Configuration menu
    Copy the full SHA
    0990061 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1663bb6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    13996c2 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Configuration menu
    Copy the full SHA
    dae9db7 View commit details
    Browse the repository at this point in the history
  2. Hotfix for the develop branch to get met-10.1.0-beta4 compiling on WC…

    …OSS. The intel compiler does not allow adjacent >> characters when defining maps.
    JohnHalleyGotway committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    9bd9946 View commit details
    Browse the repository at this point in the history
  3. Updating the beta4 release date from 11/16 to 11/17 since the beta4 r…

    …elease needs to be recreated.
    JohnHalleyGotway committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    e0b659d View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Configuration menu
    Copy the full SHA
    817d9db View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Configuration menu
    Copy the full SHA
    4e28ae7 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Configuration menu
    Copy the full SHA
    6d16e23 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. #1936 Excludes precip3hr, precip6hr, precip12hr, and precip10min from…

    … required variables for MESONET
    Howard Soh committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    39a5233 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. Configuration menu
    Copy the full SHA
    c9434e8 View commit details
    Browse the repository at this point in the history
  2. Per #1985, VERY minor change to fix alignment of titles in Point-Stat…

    …... updating the develop branch.
    JohnHalleyGotway committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    84f8c7f View commit details
    Browse the repository at this point in the history
  3. #1936 Added an unit test for newer MESONET file

    Howard Soh committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    d35190e View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. Merge pull request #1984 from dtcenter/feature_1936_madis_nc2

    Bugfix 1936 develop madis2nc
    hsoh-u committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    f81d250 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. Configuration menu
    Copy the full SHA
    8c29f09 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b93f4ea View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    49fb555 View commit details
    Browse the repository at this point in the history