Feature 2028 madis2nc profiler qc

[hsoh-u]

Expected Differences

The quality value was not handled correctly on processing profiler type input (2D variables) at seneca. Two quality marks should be added into the output NetCDF.

• maids2nc.cc: passing 2D dim and cur

• pb2nc.cc: changed a warning to a debug message if derived data exists

• Some fixes for SonarQube

  • met_point_data.cc: sets obs_data
  • mtd_file_int.cc: check the variable "d" is not null
  • pointdata_python.cc : removed un-reachable code

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  

/d1/personal/hsoh/git/features/feature_2028_madis2nc_profiler_qc/MET/met/share/met/../../bin/madis2nc \
/d1/projects/MET/MET_test_data/unit_test/obs_data/madis/profiler/profiler_20120409_1200.nc \
/d1/personal/hsoh/MET/test_output/feature_2028_madis2nc_profiler_qc/madis2nc/profiler_2012040912_F000.nc \
-type profiler \
-mask_poly /d1/personal/hsoh/git/features/feature_2028_madis2nc_profiler_qc/MET/met/share/met/poly/CONUS.poly -v 2

ncdump -v /d1/personal/hsoh/MET/test_output/feature_2028_madis2nc_profiler_qc/madis2nc/profiler_2012040912_F000.nc | less

obs_qty_table =
"S",
"Q" ;
}

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

Run the unit test add check the "madis2nc/profiler_2012040912_F000.nc"

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

• Do these changes include sufficient testing updates? [Yes or No]

• Will this PR result in changes to the test suite? [Yes]
  
  If yes, describe the new output and/or changes to the existing output:
  

No at kiowa
Yes at seneca. Two quality value at sececa

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

See the METplus Workflow for details.

• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Linked issues with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[georgemccabe]

I built MET using the feature branch on seneca and ran the madis2nc unit test. I confirmed that the obs_qty_table values match what was expected.