Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2044 pb2nc config #2050

Merged
merged 10 commits into from
Feb 17, 2022
Merged

Feature 2044 pb2nc config #2050

merged 10 commits into from
Feb 17, 2022

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Feb 12, 2022

Expected Differences

The config key "obs_prefbufr_map: was renamed to "obs_prepbufr_map". And give a warning if the config key obs_prepbufr_map is used in the configuration file.
Categories of modifications:

  • source code and comments

  • PB2NC config files (test/connfig & met/data/config)

  • User guide

  • series_analysis.cc: initialize i_point

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

Make sure there is only one instance of "prefbufr" for backward compatibility

grep -i prefbufr `find -type f` | grep -v "Binary file"
OR 
grep -i pref `find -type f` | grep -v "Binary file" | grep -i -v prefer | grep -i -v PREFIX | grep -v "program-pref" | grep -v "exec-pref" | grep -v "/.git/"
 
./met/src/basic/vx_config/config_util.cc:static const char conf_key_prepbufr_map_typo[] = "obs_prefbufr_map";    // for backward compatibility

Note: Copy PB2NCConfig_cal_pbl from seneca:/d1/personal/hsoh/git/config_to_test/PB2NCConfig_cal_pbl2

export MASK_GRID=""
export MASK_POLY=""
export QUALITY_MARK_THRESH="2"
export STATION_ID=""
 PB2NCConfig_cal_pbl    ===
./pb2nc /d1/personal/hsoh/data/PBL_data/nam.t06z.prepbufr.tm06.nr /d1/personal/hsoh/MET/MET_test_output/latest/pb2nc/nam.t06z.prepbufr.tm06.pbl.nc PB2NCConfig_cal_pbl -v 2

WARNING:
WARNING: Please rename the configuration key "obs_prefbufr_map" to "obs_prepbufr_map" at PB2NCConfig_cal_pbl (Ignored "obs_prefbufr_map" key)
WARNING:

And no warning if PB2NCConfig_cal_pbl is updated.
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u added this to the MET 10.1.0 milestone Feb 12, 2022
…ar entry should really be obs_bufr_map and not commented out.
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes. I compiled the branch locally and tested to confirm that the warning message for the incorrect "obs_prefbufr_map" is printed.

Note that I did correct one typo in PB2NCConfig_G212 and committed directly to this branch.

@hsoh-u hsoh-u merged commit 6b2134d into develop Feb 17, 2022
@hsoh-u hsoh-u deleted the feature_2044_pb2nc_config branch February 17, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the PB2NC configuration to correct the obs_prefbufr_map name as obs_prepbufr_map.
2 participants