Feature 1583 es hira

[JohnHalleyGotway]

Expected Differences

Whew, well this was a long time in coming, but should now be working as expected.

• Do these changes introduce new tools, command line arguments, or configuration file options? [Yes]
  
  If yes, please describe:
  
  In Ensemble-Stat, add support for interp.method = HIRA. For example:

interp = {
  type = [
    { method = NEAREST; width = 1; },
    { method = HIRA; width = 2; },
    { method = HIRA; width = 5; }
  ];
}

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  
  While this does not change the output line types, I want to point out 2 details:

1. The Ensemble-Stat output can now contain INTERP_MTHD = HIRA, whereas it did not previously.
2. Previously, the ensemble size remained constant for each run of the tool. With HiRA, that is no longer the case since the number of members varies based on the size of the neighborhood.

The length of the ORANK, RHIST, and RELP output line types vary based on the number of members. Running HiRA messes up the alignment of the output _orank.txt, _rhist.txt, and _relp.txt output files. In this version, the header columns are written based on the MAXIMUM number of ensemble members.

If preferred, I could modify the logic to NOT WRITE any header columns past the LINE_TYPE column when HiRA is used. So please let me know if that's preferable.

Pull Request Testing

• Describe testing already performed for these changes:
  
  Tested locally with a variety of HiRA settings to confirm it works as expected. Used GHA to confirm that these changes don't change the existing unit test output... until I modified the configuration for one.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

• @mpm-meto please review the doc updates and feel free to make recommended edits.

• @j-opatz please review the doc updates, config file changes, and see the impact of using HiRA in the output of GHA tests.

• @jprestop please review the actual code changes. Is the small test I added sufficient?

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
  Updated the Ensemble-Stat and config file chapters.

• Do these changes include sufficient testing updates? [Yes]
  I just tweaked an existing EnsembleStatConfig file that used when you run "make test". It's also used by unit_met_test_scripts.xml. Also tweaked the Stat-Analysis job that processes the Ensemble-Stat output.
  I considered modifying the configuration used in unit_ensemble_stat.xml but realized it would impact lots and lots of output files. I wanted to avoid a very large impact in the results.

• Will this PR result in changes to the test suite? [Yes]
  
  If yes, describe the new output and/or changes to the existing output:
  
  Adds HIRA output lines to the output in met_test_scripts/ensemble_stat and modifies the output of met_test_scripts/stat_analysis.

• Please complete this pull request review by [Fri 2/18/22].
  

Pull Request Checklist

See the METplus Workflow for details.

• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Linked issues with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[jprestop]

I reviewed the code changes. I think the small test you added is sufficient. I think it's good that the EnsembleStatConfig file you modified runs with "make test" and that it is used by used by unit_met_test_scripts.xml and agree that if modifying the configuration used in unit_ensemble_stat.xml would impact lots and lots of output files, we should avoid that. I approve this request.

[j-opatz]

The updated documentation looks appropriate for the changes made, and the errors in automated testing is from the expected difference in outputs. It seems like the changes made address the need for HIRA in ensembles, although I'm not too familiar with the process. From what I was reviewing for, I approve this PR.