Feature 2070 obs_prepbufr_map

[JohnHalleyGotway]

Expected Differences

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  
  No a new option, just 2 new default mapping strings.

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  
  No testing done yet. Will rely on the GHA testing.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  I grepped all of the existing unit tests for instances of HOVI and TOCC. But I found none. I present, we may have needed to rename them using their remapped names of VIS and TCDC.

I expect that the GitHub actions will run successfully. The only potential source of differences I anticipate is in the NetCDF output of PB2NC. If any of the existing tests do write HOVI and TOCC output, it will now be renamed.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
  None needed.

• Do these changes include sufficient testing updates? [Yes]
  None needed.

• Will this PR result in changes to the test suite? [MAYBE]
  
  If yes, describe the new output and/or changes to the existing output:
  
  Depends on whether or not the variable names in the PB2NC output files are modified.

• Please complete this pull request review by [Friday 2/25/22].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Linked issues with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[hsoh-u]

It's better not to override the default variable mapping (input/output) at the user configuration, PB2NCConfig_pbl., (changing obs_prepbufr_map to obs_bufr_map).

[JohnHalleyGotway]

The GHA testing did flag some differences in the output. But the differences are limited to a single PB2NC output file and do match what I would expect.

COMPARING pb2nc_indy/ndas.20120409.t12z.prepbufr.tm00.var_all.nc
file1: /data/output/met_test_truth/pb2nc_indy/ndas.20120409.t12z.prepbufr.tm00.var_all.nc
file2: /data/output/met_test_output/pb2nc_indy/ndas.20120409.t12z.prepbufr.tm00.var_all.nc
ERROR: 2 string difference(s) found in var obs_var

Here are the actual diffs showing TOCC and HOVI renamed to TCDC and VIS, as expected:

ncdump -v obs_var ndas.20120409.t12z.prepbufr.tm00.var_all_TRUTH.nc > truth
ncdump -v obs_var ndas.20120409.t12z.prepbufr.tm00.var_all_OUTPUT.nc > output
diff truth output
198c198
<   "TOCC",
---
>   "TCDC",
202c202
<   "HOVI",
---
>   "VIS",