Feature 1996 sonarqube findings

[hsoh-u]

Expected Differences

No differences except SonarCube scanning result at MET_develop_NB

• vx_config/threshold.cc: tf_left was used at the previous return statement

• vx_util/ascii_table.cc: checks NULL pointer for "p"

• vx_shapedata/interest.cc: reduced the duplicated for loops (SonarQube complains a potential memory access error)

• vx_tc_util/genesis_info.h: "bool IsSet" is defined at the base class

• Initialize variables at the other files

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

Run unit test and check nothing is changed

• Describe testing already performed for these changes:
  

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

• Do these changes include sufficient testing updates? [No]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Linked issues with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[JohnHalleyGotway]

I approve of these changes.

Note that the GHA tests only failed with a difference due to a recently approved PR. I just merged the latest from develop into this feature branch which triggered the GHA tests to rerun. No differences should be flagged anymore.

I recommend waiting for that to happen (by 6:30pm on 2/28/22) prior to actually merging this PR.