Feature 1259 BIN_MEAN OBS_THRESH #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, PRJ, and ECLV outputs from ensemble-stat. Also added fcat_ta and ocat_ta ThreshArray objects to store the needed fcst and obs thresholds. Still need to actually update ensemble_stat.cc to use them and also need to make config file, unit test, and documentation updates.
…he writing of STAT output lines for both point and gridded verification into a common write_txt_files() function. In the process, I discovered that we were checking the top-level conf_info.output_flag option instead of the vx_opt specific ones. These changes switch to using the vx_opt ones so that we can control the output written task by task.
…tat output lines.
…stat to define how PCT thresholds. Still need to update documentation, tests, and config files.
…istic outputs in 2 ways.
…nsistent with the default one.
…as consistent as possible with the default configuration.
…tput files created by ensemble-stat.
…utation of binned percentile thresholds.
…ether the total column should be summed or averaged. Previously, they were always summed since the climo bins were used to SUBSET the matched pairs. In Ensemble-Stat, the full set of pairs can now thresholded multiple times based on the climo bins. As such, the TOTAL value for each input should remain constant. Rather then summing those totals, they should now be averaged (but this is the average of a constant value).
…ut for climo distribution percentile thresholds. Instead of writing OBS_THRESH using the value from the first bin, explicitly write it as '==CDP####' where #### is 100/climo_cdf.n_bin. That better indicates the climo bins used to compute the mean statistics.
JohnHalleyGotway
changed the title
j-opatz
approved these changes
Mar 3, 2022
21 tasks
JohnHalleyGotway
added a commit
that referenced
this pull request
Mar 3, 2022
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu> Co-authored-by: johnhg <johnhg@ucar.edu> Co-authored-by: Seth Linden <linden@kiowa.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com> Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@kiowa.rap.ucar.edu> Co-authored-by: jprestop <jpresto@ucar.edu> Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: Seth Linden <linden@ucar.edu> Co-authored-by: hsoh-u <hsoh@ucar.edu> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: John Halley Gotway <johnhg@seneca.rap.ucar.edu> Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu> Co-authored-by: mo-mglover <78152252+mo-mglover@users.noreply.github.com> Co-authored-by: davidalbo <dave@ucar.edu> Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com>
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
@j-opatz I went ahead and submitted this PR to change the OBS_THRESH column for the BIN_MEAN probabilistic output from Ensemble-Stat using CDP thresholds from ">=CDP10" to "==CDP10". If you don't think this is good change for RC1, just let me know and we can delete this PR.
Do these changes introduce new tools, command line arguments, or configuration file options? [Yes or No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Manually reran unit_climatology_1.0deg.xml to confirm that the OBS_THRESH column changed as expected.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
This small difference should be flagged by the GHA testing workflow. Just inspect the flagged difference to confirm that ">=CDP10" has actually changed to "==CDP10".
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [No]
Didn't update any docs. Don't know where/what changes, if any, are needed.
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
See above.
Please complete this pull request review by [Thurs 3/3].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes