Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1904 req args #2087

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Feature 1904 req args #2087

merged 1 commit into from
Mar 7, 2022

Conversation

JohnHalleyGotway
Copy link
Collaborator

Expected Differences

Fixing a very minor copy/paste bug in Gen-Ens-Prod.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Prior to the bugfix, it does not tell you that -out is required:
gen_ens_prod  -ens data/sample_fcst/2009123112/arw-*/*.grib -config data/config/EnsembleStatConfig_default
ERROR  : process_ensemble() -> 0 of 6 (0) fields found for "APCP/A03" does not meet the threshold specified by "ens.ens_thresh" (1) in the configuration file.

After the bugfix, it does:

gen_ens_prod -ens data/sample_fcst/2009123112/arw-*/*.grib -config data/config/EnsembleStatConfig_default 
ERROR  : process_command_line() -> the output file must be set using the "-out" option.
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    No additional testing needed. Just review the one-line code change.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    None needed.

  • Do these changes include sufficient testing updates? [No]
    None needed.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Monday 3/7].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…cking the length of config_file instead of out_file. This became obvious when running gen_ens_prod without the -out option. That run segfaulted because it tried to create an output file using an empty string.
@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.1.0 milestone Mar 6, 2022
@JohnHalleyGotway JohnHalleyGotway linked an issue Mar 6, 2022 that may be closed by this pull request
23 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this one line change and the new bugfix output. I approve this pull request.

@JohnHalleyGotway JohnHalleyGotway merged commit de2f9b8 into develop Mar 7, 2022
@JohnHalleyGotway JohnHalleyGotway deleted the feature_1904_req_args branch March 7, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the new Gen-Ens-Prod tool for ensemble product generation.
2 participants