Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 2123 main v10.1 nccf valid time #2126

Merged
merged 4 commits into from
Apr 6, 2022

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Apr 6, 2022

Expected Differences

The problem was caused by the int64 type time variable which was not supported yet.
Before: time information was not from valid_time variable which has the standard_name = "time"

DEBUG 4: Data plane information:
DEBUG 4:    plane min: 0
DEBUG 4:    plane max: 2.10354
DEBUG 4:    valid time: 19700101_000000
DEBUG 4:    lead time: 000000
DEBUG 4:    init time: 19700101_000000
DEBUG 4:    accum time: 000000

after supporting int64 data type:

DEBUG 4: Data plane information:
DEBUG 4:    plane min: 0
DEBUG 4:    plane max: 2.10354
DEBUG 4:    valid time: 20220221_000000
DEBUG 4:    lead time: 000000
DEBUG 4:    init time: 20220221_000000
DEBUG 4:    accum time: 000000
  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

The input data exists at #2123
plot_data_plane obs.nc obs.ps 'name="precipitation"; level="(,)";' -title "Observation precipitation" -v 4
OR
/d1/personal/hsoh/git/bugfixes/bugfix_2123_main_v10.1_nccf_valid_time/MET/met/bin/plot_data_plane /d1/personal/hsoh/data/MET-2123/obs.nc obs.ps 'name="precipitation"; level="(,)";' -title "Observation precipitation" -v 4

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

The same test

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

JohnHalleyGotway and others added 3 commits April 5, 2022 12:49
…, reproducible on seneca. Just initialize the newly allocated time_values array with values of -10. PLEASE REMOVE THAT TEST CODE PRIOR TO SUBMITTING A PR TO FIX THIS ISSUE.
@hsoh-u hsoh-u added this to the MET 10.1.1 (bugfix) milestone Apr 6, 2022
@JohnHalleyGotway JohnHalleyGotway linked an issue Apr 6, 2022 that may be closed by this pull request
22 tasks
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes. I ran the test indicated on seneca and confirmed the expected result.

@hsoh-u hsoh-u merged commit 62376a8 into main_v10.1 Apr 6, 2022
@hsoh-u hsoh-u deleted the bugfix_2123_main_v10.1_nccf_valid_time branch April 6, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Fix support for int64 NetCDF variable types.
2 participants