Bugfix 2123 main v10.1 nccf valid time #2126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
The problem was caused by the int64 type time variable which was not supported yet.
Before: time information was not from valid_time variable which has the standard_name = "time"
after supporting int64 data type:
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
The input data exists at #2123
plot_data_plane obs.nc obs.ps 'name="precipitation"; level="(,)";' -title "Observation precipitation" -v 4
OR
/d1/personal/hsoh/git/bugfixes/bugfix_2123_main_v10.1_nccf_valid_time/MET/met/bin/plot_data_plane /d1/personal/hsoh/data/MET-2123/obs.nc obs.ps 'name="precipitation"; level="(,)";' -title "Observation precipitation" -v 4
The same test
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
Do these changes include sufficient testing updates? [No]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes