Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature dtcenter/METplus-Internal#16 sonarqube python #2159

Merged
merged 4 commits into from
Jun 14, 2022

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented May 11, 2022

Expected Differences

Activated sonarqube scanning for python

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

/d1/personal/hsoh/git/features/feature_METplus-Internal_16_sonarqube_python/MET/scripts/sonarqube/run_nightly.sh debug

OR

switch use to met_test
runas met_test
/d1/projects/MET/MET_regression/MET-develop/scripts/sonarqube/run_nightly.sh debug

And check the SonarQube server at http://mandan:9000/projects
go to "MET python Nightly Build"

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u added this to the MET 11.0.0 milestone May 11, 2022
@hsoh-u hsoh-u changed the title METplus internal #16 sonarqube python Feature dtcenter/METplus-Internal#16 sonarqube python May 11, 2022
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsoh-u I approve of these changes. I see that they're confined to the internal/scripts/sonarqube directory and will not affect any of the actually functionality of the MET tools.

I see that you've already tested them to confirm that they work as expected. But I do recall you mentioning some potential issue after the repo was restructured. I'll leave it to you to work through all those details.

@hsoh-u hsoh-u merged commit 8d4e4d4 into develop Jun 14, 2022
@hsoh-u hsoh-u deleted the feature_METplus-Internal_16_sonarqube_python branch June 14, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants