Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1815 level value #2203

Merged
merged 4 commits into from
Jul 18, 2022
Merged

Feature 1815 level value #2203

merged 4 commits into from
Jul 18, 2022

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Jul 7, 2022

Expected Differences

No differences except support @NNN for vertical level and time.
New output (plot_data_plane/gtg_obs_forecast.20130730.i00.f00.NCCF_latlon_20000.ps) is added to unit test.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

No, it's a change to the level configuration.

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

Input file with "axis"=Z

#using z=20000 (flight level in feet)
/d1/personal/hsoh/git/features/feature_1815_level_value/MET/bin/plot_data_plane /d1/projects/MET/MET_test_data/unit_test/model_data/nccf/gtg/latlon/gtg_obs_forecast.20130730.i00.f00.nc slice_pressure_value_20000_1.ps 'name = "edr"; level = "(0,20000,*,*)";' -title "NCCF Latitude/Longitude Level 0" -v 7

#using integer value @20000 (flight level in feet)
/d1/personal/hsoh/git/features/feature_1815_level_value/MET/bin/plot_data_plane /d1/projects/MET/MET_test_data/unit_test/model_data/nccf/gtg/latlon/gtg_obs_forecast.20130730.i00.f00.nc slice_pressure_value_20000_2.ps 'name = "edr"; level = "(0,@20000,*,*)";' -title "NCCF Latitude/Longitude Level 0" -v 7

#using float value @20000.0 (flight level in feet)
/d1/personal/hsoh/git/features/feature_1815_level_value/MET/bin/plot_data_plane /d1/projects/MET/MET_test_data/unit_test/model_data/nccf/gtg/latlon/gtg_obs_forecast.20130730.i00.f00.nc slice_pressure_value_20000f.ps 'name = "edr"; level = "(0,@20000.0,*,*)";' -title "NCCF Latitude/Longitude Level 0" -v 7

Input file without "axis"=Z, but with the same variable name with the dimension name for the vertical level ("lev")

#using float value @7.59481964632869
/d1/personal/hsoh/git/features/feature_1815_level_value/MET/bin/plot_data_plane /d1/projects/MET/MET_test_data/unit_test/model_data/easm/b.e15.B1850.f09_g16.pi_control.all_ga7cpl24.66.cam.i.0083-01-01-00000.nc same_dim_var_name.ps 'name = "T"; level = "(0,@7.59481964632869,*,*)";' -title "NCCF Latitude/Longitude Level 0" -v 7

Using offset only (failed with METplus test case):
This is a special case. The time dimension for "U" variable is "valid_time", but the "forecast_reference_time" dimension is applied by MET tools. The existing code considered "valid_time" dimension as non time dimension. Now it's fixed.
There is 6 hour difference between valid_time (2019-08-29 12:00:00) and forecast_reference_time (2019-08-29 18:00:00). @20190829_120000 does not work but @20190829_180000 works.

--- netcdf file---
dimensions:
        latitude = 2001 ;
        lev = 4 ;
        longitude = 3501 ;
        valid_time = 1 ;
        forecast_reference_time = 1 ;

double valid_time(valid_time) ;
        valid_time:units = "seconds since 2019-08-29 12:00:00" ;
double forecast_reference_time(forecast_reference_time) ;
        forecast_reference_time:units = "seconds since 1970-01-01 00:00" ;

 double u(valid_time, lev, latitude, longitude) ;

--- netcdf file---

/d1/personal/hsoh/git/features/feature_1815_level_value/MET/bin/plot_data_plane /d1/projects/METplus/METplus_Data/model_applications/tc_and_extra_tc/GridStat_fcstHAFS_obsTDR_NetCDF/hafs_height/dorian05l.2019082912.hafsprs.synoptic.0p03.f000.nc4 out-test.ps 'name="u"; level="(0,1,*,*)";' -v 9
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

One unit test is added * one unit test is changed (but it gets the same output)

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

New unit test is added (plot_data_plane/gtg_obs_forecast.20130730.i00.f00.NCCF_latlon_20000.ps).
YYYYMMDD_HHMMDD is changed to @YYYYMMDD_HHMMDD at unit test definition file

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Collaborator

@georgemccabe georgemccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the example plot_data_plane that had previously failed in the METplus use case tests and it looks like it runs as expected. I approve.

@hsoh-u hsoh-u merged commit 3d13abc into develop Jul 18, 2022
JohnHalleyGotway added a commit that referenced this pull request Jul 25, 2022
Co-authored-by: johnhg <johnhg@ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@kiowa.rap.ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
Co-authored-by: Randy Bullock <bullock@seneca.rap.ucar.edu>
Co-authored-by: davidfillmore <fillmore.winslow.david@gmail.com>
Co-authored-by: rgbullock <bullock@ucar.edu>
Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: Seth Linden <linden@kiowa.rap.ucar.edu>
Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu>
Co-authored-by: Seth Linden <linden@ucar.edu>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@seneca.rap.ucar.edu>
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Co-authored-by: mo-mglover <78152252+mo-mglover@users.noreply.github.com>
Co-authored-by: davidalbo <dave@ucar.edu>
Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com>
Co-authored-by: Dan Adriaansen <dadriaan@ucar.edu>
Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu>
Co-authored-by: Molly Smith <molly.b.smith@noaa.gov>
@hsoh-u hsoh-u deleted the feature_1815_level_value branch November 2, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants