Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
No differences except support @NNN for vertical level and time.
New output (plot_data_plane/gtg_obs_forecast.20130730.i00.f00.NCCF_latlon_20000.ps) is added to unit test.
If yes, please describe:
No, it's a change to the level configuration.
If yes, please describe:
Pull Request Testing
Input file with "axis"=Z
Input file without "axis"=Z, but with the same variable name with the dimension name for the vertical level ("lev")
Using offset only (failed with METplus test case):
This is a special case. The time dimension for "U" variable is "valid_time", but the "forecast_reference_time" dimension is applied by MET tools. The existing code considered "valid_time" dimension as non time dimension. Now it's fixed.
There is 6 hour difference between valid_time (2019-08-29 12:00:00) and forecast_reference_time (2019-08-29 18:00:00). @20190829_120000 does not work but @20190829_180000 works.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
One unit test is added * one unit test is changed (but it gets the same output)
If yes, describe the new output and/or changes to the existing output:
New unit test is added (plot_data_plane/gtg_obs_forecast.20130730.i00.f00.NCCF_latlon_20000.ps).
YYYYMMDD_HHMMDD is changed to @YYYYMMDD_HHMMDD at unit test definition file
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes