Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2211 log_msg #2212

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Feature #2211 log_msg #2212

merged 1 commit into from
Jul 27, 2022

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Jul 26, 2022

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Confirmed the code compiles and ran MODE with an bad configuration conv_thresh = 2.5; to trigger the following error message:
ERROR  : Dictionary::lookup_thresh_array() -> each threshold in array "conv_thresh" must start with a valid comparison operator (<, <=, ==, !=, >, >=, lt, le, eq, ne, gt, ge).

And confirmed with @jvigh that the wording is clear.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Just confirm that all the GHA tests pass and review the small number of code changes.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
    None needed.

  • Do these changes include sufficient testing updates? [Yes]
    None needed.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Wed 7/27/22].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.0 milestone Jul 26, 2022
@JohnHalleyGotway JohnHalleyGotway linked an issue Jul 26, 2022 that may be closed by this pull request
20 tasks
Copy link
Contributor

@jvigh jvigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good! This enhancement will help future users if they forget the operator.

@jvigh jvigh merged commit 5f1899a into develop Jul 27, 2022
@jvigh jvigh deleted the feature_2211_log_msg branch July 27, 2022 14:39
@jvigh
Copy link
Contributor

jvigh commented Jul 27, 2022

Merged this PR and deleted the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Refine warning/error messages when parsing thresholds.
2 participants