Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #2208 ensemble_stat with missing members #2213

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Jul 27, 2022

Expected Differences

MET builds 8 ensemble members for PRMSL and 10 members for VIS when the input ensemble list contains the missing members. But last two members for VIS are empty list (no data). I'm not sure the design for missing members.
The fix is just checking if member data is available.
The other solution would be:

  • Filling with missing values (by adding 2 missing members for PRMSL - make same 10 members for VIS and PRMSL)

  • Removing 2 empty members for VIS (make same 8 members for VIS and PRMSL)

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

Run /d1/personal/hsoh/data/MET-2208/run.sh where "ensemble_stat" executable exists at seneca

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Collaborator

@georgemccabe georgemccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change here is a quick fix that Howard and I discussed should fix the issue. However, I will defer to @JohnHalleyGotway since he is more familiar with the code and may have a suggestion for a more robust fix.

@JohnHalleyGotway JohnHalleyGotway changed the title feature 2208 ensemble_stat with missing members Feature #2208 ensemble_stat with missing members Jul 27, 2022
@JohnHalleyGotway JohnHalleyGotway changed the title Feature #2208 ensemble_stat with missing members Bugfix #2208 ensemble_stat with missing members Jul 27, 2022
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.0 milestone Jul 27, 2022
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this change. Thanks for tracking it down @hsoh!

I'll rely on the testing you and @georgemccabe to confirm that what had been broken now works. I do see that GHA ran without error and flagged no differences.

I reviewed the logic of the code change and see that it makes sense.

@hsoh-u hsoh-u merged commit c0d6397 into develop Jul 27, 2022
@hsoh-u hsoh-u deleted the bugfix_2208_ensemble_stat_missing_member branch July 28, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Fix Ensemble-Stat to work with different missing members for two or more variables
3 participants