Feature #2224 nbrhd_prob #2331
Merged
Feature #2224 nbrhd_prob #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollowing types of warnings: WARNING: process_command_line() -> control_id is set in the config file but control file is not provided with -ctrl argument
…g the field entry for the nbrhd_prob. This seems preferable to all the duplication involved in writing a new parse_conf_nbrhd_prob() function.
20 tasks
michelleharrold
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
@JohnHalleyGotway - I looked through the changes to config_util.cc, and everything looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to eliminate a confusing warning message when running Gen-Ens-Prod via METplus. Should be no changes to the output of the unit tests.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Tested manually with local builds to trigger the warning message on the develop branch and confirm that it does not appear on this feature branch.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review code changes.
Confirm that all unit tests run via GHA and trigger no diffs.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
None needed.
Do these changes include sufficient testing updates? [No]
None needed.
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Mon 11/7/22].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes