-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #2339 stat_analysis_seeps #2343
Merged
JohnHalleyGotway
merged 9 commits into
feature_1943_gridstat_seeps
from
feature_2339_stat_analysis_seeps
Nov 12, 2022
Merged
Feature #2339 stat_analysis_seeps #2343
JohnHalleyGotway
merged 9 commits into
feature_1943_gridstat_seeps
from
feature_2339_stat_analysis_seeps
Nov 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gate these properly.
…s to fix memory issues.
…type SEEPS_MPR -out_line_type SEEPS. While this runs, I still need to test it.
…o feature_2339_stat_analysis_seeps
22 tasks
hsoh-u
approved these changes
Nov 12, 2022
@hsoh-u, FYI, I saw an error in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hsoh-u I'd like to merge my Stat-Analysis changes for SEEPS back into your feature branch.
** IMPORTANT ** there's memory management problems in computing the seeps density that are fixed here using STL vectors.
These Stat-Analysis change include...
-job filter
for-line_type SEEPS
and-line_type SEEPS_MPR
.-job summary
for columns in SEEPS and/or SEEPS_MPR.-job aggregate
for-line_type SEEPS
.-job aggregate_stat
for-line_type SEEPS_MPR -out_line_type SEEPS
.test_unit/xml/unit_stat_analysis_ps.xml
to demonstrate.Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
The Stat-Analysis jobs that I added demonstrate that the filtering, summary, and aggregation logic.
But that logic is VERY simplistic.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
Adds new Stat-Analysis output.
Please complete this pull request review by [Mon 11/14/22].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes