-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #2366 pyembed_winds #2371
Conversation
…() function. Only enforce this check if the requested levels are non-empty. Note that they ARE empty for python embedding.
…nt a warning message if multiple matches are found. Should this be an error instead?
…int-Stat and Grid-Stat to call it. Update logic to use the FIRST U/V match found and indicate that in the log message.
… processing via python embedding using fake data.
@georgemccabe based on our discussion on 12/6/22, I made the changes seen in these 2 commits:
Note that this will change the contents of an existing output file from the unit tests and will be flagged as a difference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good. @JohnHalleyGotway and I met briefly yesterday to discuss the changes. John made some adjustments based on our conversation to reduce duplicate logic and added a unit test to ensure that the new functionality works as expected. The only failed check is due to new output data being generated from the changes to the unit tests.
The truth data will need to be updated after this PR is merged. I approve.
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu> Co-authored-by: johnhg <johnhg@ucar.edu> Co-authored-by: Lisa Goodrich <lisag@seneca.rap.ucar.edu> Co-authored-by: jprestop <jpresto@ucar.edu> Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu> Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu> Co-authored-by: Jonathan Vigh <jvigh@ucar.edu> Co-authored-by: hsoh-u <hsoh@ucar.edu> Co-authored-by: bikegeek <3753118+bikegeek@users.noreply.github.com> Co-authored-by: davidalbo <dave@ucar.edu> Co-authored-by: Seth Linden <linden@ucar.edu> Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com> Co-authored-by: Daniel Adriaansen <dadriaan@ucar.edu>
This PR includes the following changes:
Should I include the magic string (i.e. name/level) in the log message or is the number sufficient?
Should this WARNING actually be an error?
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
While there's no NEW config file option, it does allow the level string to be defined for python embedding.
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Tested Grid-Stat with python embedding for both fcst/obs to get successful runs and trigger Debug/Warning messages.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review the code changes.
Ensure all GHA runs pass and produce no diffs.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
No doc updates included.
Do these changes include sufficient testing updates? [Yes or No]
No new unit tests added.
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Wed 12/7/22].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes