Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2415 develop modulefiles #2417

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Conversation

jprestop
Copy link
Collaborator

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Used these modulefiles to set up the environment for users on various machines

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    None. Review files if desired.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [N/A]

  • Do these changes include sufficient testing updates? [N/A]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [20230125].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    NOTE: No applicable MET Project available, chose METplus Version 5.0 Support as an umbrella project.
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the MET 11.1.0 milestone Jan 20, 2023
@jprestop jprestop linked an issue Jan 20, 2023 that may be closed by this pull request
21 tasks
@jprestop jprestop changed the title Updated module and config files Feature 2415 modulefiles Jan 20, 2023
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes.

Julie, I definitely defer to you on all these installation file updates. I browsed the list of modified files and see that several version 10 files are deleted while version 11 files are added. And compile_MET_all.sh is updated.

@JohnHalleyGotway JohnHalleyGotway changed the title Feature 2415 modulefiles Feature #2415 develop modulefiles Jan 25, 2023
@jprestop
Copy link
Collaborator Author

@JohnHalleyGotway Thank you so much for mentioning "And compile_MET_all.sh is updated." That should not have been the case. I'm not sure why, but it was reverting all of the changes that George made. I was able to resolve it. I will wait for the tests to rerun and then squash and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add modulefiles for supported systems to the repository
2 participants