-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix #2437 main_v11.0 convert #2438
Commits on Feb 3, 2023
-
Per #2437, calls to convert() and censor() DO NOT belong in the regri…
…dding logic. This was the source of the climo conversion logic being applied twice. It was applied when reading the climo data, and then again after regridding it to the verification domain. The convert() and censor() options should only be applied when READING data, not when processing it. Run a full regression test to make sure this change does not break any unit tests ci-run-unit
Configuration menu - View commit details
-
Copy full SHA for 90f92f4 - Browse repository at this point
Copy the full SHA 90f92f4View commit details
Commits on Feb 4, 2023
-
Per #2437, the convert and censor logic was intentionally added to th…
…e RegridInfo struct in #1293. Instead of removing it entirely, I'll try to limit the scope of parsing those entries to just the regrid dictionary WITHOUT doing any lookup in its parents.
Configuration menu - View commit details
-
Copy full SHA for f42005d - Browse repository at this point
Copy the full SHA f42005dView commit details -
Per #2437, ci-run-unit Add search_parent boolean agrument to the look…
…up functions in the Dictionary class. This will enable us to control whether or not the higher levels of config file context should be searched. In the case of regrid.convert(x), regrid.censor_thresh, and regrid.censor_val, the parents should NOT be searched to avoid their double application. Running the full regression test to see if this change breaks anything.'
Configuration menu - View commit details
-
Copy full SHA for c4b498b - Browse repository at this point
Copy the full SHA c4b498bView commit details -
Per #2437, remove deprecated match_month entry from Grid-Stat config …
…files. I also checked METplus and do not see it in the wrapped Grid-Stat config file.
Configuration menu - View commit details
-
Copy full SHA for a8beeb7 - Browse repository at this point
Copy the full SHA a8beeb7View commit details -
Merge branch 'bugfix_2437_main_v11.0_convert' of https://github.com/d…
…tcenter/MET into bugfix_2437_main_v11.0_convert
Configuration menu - View commit details
-
Copy full SHA for 43e703f - Browse repository at this point
Copy the full SHA 43e703fView commit details -
Per #2437, patch the climo time interpolation logic for when exactly …
…2 climo records are found but the target valid time does not fall between them. Instead of erroring out, update the climo times to match the date (year, month, day) of the valid time. Then proceed with the interpolation logic.
Configuration menu - View commit details
-
Copy full SHA for 2188688 - Browse repository at this point
Copy the full SHA 2188688View commit details
Commits on Feb 5, 2023
-
Per #2437, update the Point-Stat 2.5 deg climo unit test to use set_a…
…ttr_units option. Port over existing Grid-Stat unit test to demonstrate wrapping the year. And add another Grid-Stat unit test to use only a single monthly input climo file.
Configuration menu - View commit details
-
Copy full SHA for e26f3be - Browse repository at this point
Copy the full SHA e26f3beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9dda652 - Browse repository at this point
Copy the full SHA 9dda652View commit details -
Configuration menu - View commit details
-
Copy full SHA for bebbead - Browse repository at this point
Copy the full SHA bebbeadView commit details
Commits on Feb 6, 2023
-
Per #2437, back out the match day logic from vx_cal that is no longer…
… needed and refine the logic for updating the climo timestamps by shifting them a fixed number of days.
Configuration menu - View commit details
-
Copy full SHA for d638237 - Browse repository at this point
Copy the full SHA d638237View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d8c83d - Browse repository at this point
Copy the full SHA 2d8c83dView commit details