-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #2421 update base image #2440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PYTHON_EXE" This reverts commit 9e8b8e2.
…ython Embedding point obs without having to set PYTHONPATH
…d when MET_PYTHON_EXE is not set) so Python Embedding point obs scripts can find met_point_obs without setting PYTHONPATH
…ls in MET code. This ensures that the Python libraries/packages from the version of Python used to install MET are used instead of the user's version. The value set here corresponds to the version of Python used to install MET on seneca. This info (/usr/local/met-python3) will have to be passed into MET on the configure step to set this value properly based on the install environment.
…of LIB_LIBPNG. Added missing colons so that a colon is added before the new values if the corresponding variable is set
… it is still needed, update comment to explain why, otherwise remove it
…ure command will properly install with zlib support. Update echo of HDF5 configure command to match what is being called
…l arguments to make that allows multi job compilation to speed up installs
…that all tests run successfully when MET is compiled that way, ci-run-unit
… file and old zip file
…ws the compilation script to be used to create the METbaseimage to install only the external libraries needed to install MET
…_LIBS to any non-empty value
… to create or empty directories to use full paths to remove with wildcard
…onfig file instead of having to modify script to install them
…ent of rest of code
… logs can be more easily captured
…et files in same area as bin
…script removes this flag from g2clib and MET and this library must match to prevent runtime errors
…be necessary if we move to using 1.6.4+
…d of /met/external_libs, ci-run-unit
22 tasks
JohnHalleyGotway
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of these changes.
- I inspected the 7 modified files and the changes look reasonable to me.
- While all the unit tests ran, several differences in the output are flagged, and they care shown below. None of them are problematic.
- Very small numeric differences in partial sums and wavelet decompositions.
- Some larger diffs in observation values derived by PB2NC, but still less than 0.01.
- Diffs in png image files, but visual inspection reveals no visual differences.
egrep -i "file1:|ERROR:" comp_dir.log | egrep -B1 ERROR
file1: /data/output/met_test_truth/grid_stat/grid_stat_GFS_FOURIER_240000L_20120410_000000V.stat
ERROR: found 8 differences in row type CNT column FBAR - max abs: 0.00000000000000008326
ERROR: found 8 differences in row type CNT column OBAR - max abs: 0.00000000000000002775
ERROR: found 8 differences in row type CNT column ME - max abs: 0.000000000000000013115
ERROR: found 8 differences in row type CNT column ME2 - max abs: 0.0000000000000000000000000000000022368
ERROR: found 8 differences in row type SAL1L2 column FABAR - max abs: 0.00000000000000006939
ERROR: found 8 differences in row type SAL1L2 column OABAR - max abs: 0.0000000000000000763
ERROR: found 8 differences in row type SL1L2 column FBAR - max abs: 0.00000000000000008326
ERROR: found 8 differences in row type SL1L2 column OBAR - max abs: 0.00000000000000002775
ERROR: failed tests for CNT: num
ERROR: failed tests for SAL1L2: num
ERROR: failed tests for SL1L2: num
file1: /data/output/met_test_truth/grid_stat/grid_stat_GFS_FOURIER_240000L_20120410_000000V_pairs.nc
ERROR: found 2 differences in var FCST_HGT_P500_FULL_WV1_0-72 - max abs: 0.0004882812
--
file1: /data/output/met_test_truth/mode_graphics/mode_120000L_20050807_120000V_000000A_obj_obs_simple.png
ERROR: diff error:
file1: /data/output/met_test_truth/mode_graphics/mode_120000L_20050807_120000V_120000A_obj_obs_simple.png
ERROR: diff error:
file1: /data/output/met_test_truth/mode_graphics/mode_240000L_20050808_000000V_240000A_obj_obs_simple.png
ERROR: diff error:
--
file1: /data/output/met_test_truth/pb2nc_indy/nam.20210311.t00z.prepbufr.tm00.pbl.nc
ERROR: found 34 differences in var obs_val - max abs: 0.008544922
--
file1: /data/output/met_test_truth/pb2nc_indy/ndas.20120409.t12z.prepbufr.tm00.var_all.nc
ERROR: found 1 differences in var obs_val - max abs: 0.001953125
--
file1: /data/output/met_test_truth/plot_tc/ABS_AMAX_WIND-BMAX_WIND_boxplot.png
ERROR: diff error:
file1: /data/output/met_test_truth/plot_tc/TK_ERR_boxplot.png
ERROR: diff error:
14 tasks
georgemccabe
added a commit
to dtcenter/METplus
that referenced
this pull request
Feb 16, 2023
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL REMAINING METPLUS USE CASE ISSUE HAS BEEN RESOLVED
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Confirm differences in test output are expected/acceptable
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by 2/13/2023.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes