Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2421 update base image #2440

Merged
merged 76 commits into from
Feb 16, 2023
Merged

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Feb 8, 2023

DO NOT MERGE UNTIL REMAINING METPLUS USE CASE ISSUE HAS BEEN RESOLVED

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Confirm differences in test output are expected/acceptable

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by 2/13/2023.

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…ython Embedding point obs without having to set PYTHONPATH
…d when MET_PYTHON_EXE is not set) so Python Embedding point obs scripts can find met_point_obs without setting PYTHONPATH
…ls in MET code. This ensures that the Python libraries/packages from the version of Python used to install MET are used instead of the user's version. The value set here corresponds to the version of Python used to install MET on seneca. This info (/usr/local/met-python3) will have to be passed into MET on the configure step to set this value properly based on the install environment.
…of LIB_LIBPNG. Added missing colons so that a colon is added before the new values if the corresponding variable is set
… it is still needed, update comment to explain why, otherwise remove it
…ure command will properly install with zlib support. Update echo of HDF5 configure command to match what is being called
…l arguments to make that allows multi job compilation to speed up installs
…that all tests run successfully when MET is compiled that way, ci-run-unit
…ws the compilation script to be used to create the METbaseimage to install only the external libraries needed to install MET
… to create or empty directories to use full paths to remove with wildcard
…onfig file instead of having to modify script to install them
@georgemccabe georgemccabe added this to the MET 11.1.0 milestone Feb 8, 2023
@georgemccabe georgemccabe linked an issue Feb 8, 2023 that may be closed by this pull request
22 tasks
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes.

  • I inspected the 7 modified files and the changes look reasonable to me.
  • While all the unit tests ran, several differences in the output are flagged, and they care shown below. None of them are problematic.
    • Very small numeric differences in partial sums and wavelet decompositions.
    • Some larger diffs in observation values derived by PB2NC, but still less than 0.01.
    • Diffs in png image files, but visual inspection reveals no visual differences.
egrep -i "file1:|ERROR:" comp_dir.log  | egrep -B1 ERROR
file1: /data/output/met_test_truth/grid_stat/grid_stat_GFS_FOURIER_240000L_20120410_000000V.stat
ERROR: found     8 differences in row type CNT          column FBAR          - max abs: 0.00000000000000008326 
ERROR: found     8 differences in row type CNT          column OBAR          - max abs: 0.00000000000000002775 
ERROR: found     8 differences in row type CNT          column ME            - max abs: 0.000000000000000013115 
ERROR: found     8 differences in row type CNT          column ME2           - max abs: 0.0000000000000000000000000000000022368 
ERROR: found     8 differences in row type SAL1L2       column FABAR         - max abs: 0.00000000000000006939 
ERROR: found     8 differences in row type SAL1L2       column OABAR         - max abs: 0.0000000000000000763 
ERROR: found     8 differences in row type SL1L2        column FBAR          - max abs: 0.00000000000000008326 
ERROR: found     8 differences in row type SL1L2        column OBAR          - max abs: 0.00000000000000002775 
ERROR: failed tests for CNT: num
ERROR: failed tests for SAL1L2: num
ERROR: failed tests for SL1L2: num
file1: /data/output/met_test_truth/grid_stat/grid_stat_GFS_FOURIER_240000L_20120410_000000V_pairs.nc
ERROR: found     2 differences in var FCST_HGT_P500_FULL_WV1_0-72            - max abs: 0.0004882812 
--
file1: /data/output/met_test_truth/mode_graphics/mode_120000L_20050807_120000V_000000A_obj_obs_simple.png
ERROR: diff error:
file1: /data/output/met_test_truth/mode_graphics/mode_120000L_20050807_120000V_120000A_obj_obs_simple.png
ERROR: diff error:
file1: /data/output/met_test_truth/mode_graphics/mode_240000L_20050808_000000V_240000A_obj_obs_simple.png
ERROR: diff error:
--
file1: /data/output/met_test_truth/pb2nc_indy/nam.20210311.t00z.prepbufr.tm00.pbl.nc
ERROR: found    34 differences in var obs_val                                - max abs: 0.008544922 
--
file1: /data/output/met_test_truth/pb2nc_indy/ndas.20120409.t12z.prepbufr.tm00.var_all.nc
ERROR: found     1 differences in var obs_val                                - max abs: 0.001953125 
--
file1: /data/output/met_test_truth/plot_tc/ABS_AMAX_WIND-BMAX_WIND_boxplot.png
ERROR: diff error:
file1: /data/output/met_test_truth/plot_tc/TK_ERR_boxplot.png
ERROR: diff error:

@georgemccabe georgemccabe merged commit eb987a4 into develop Feb 16, 2023
@georgemccabe georgemccabe deleted the feature_2421_update_base_image branch February 16, 2023 21:57
georgemccabe added a commit to dtcenter/METplus that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Upgrade to using Python 3.10.4
2 participants