Feature 2460 dropdown menu appendix a

[lisagoodrich]

Expected Differences

• Do these changes introduce new tools, command line arguments, or configuration file options? [n/a]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  
  I have created dropdown menus for all questions in the Q & A section. I have tested all of the dropdown menu functions.
  This was not part of the task but once I changed the indentation to accommodate the dropdown menus, this threw off the line spacing. Some lines went over the 79 characters per line. I made sure the new spacing is under 79 characters per line. Exceptions to this include, code blocks, web addresses or headers.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  Please make sure I didn't miss any questions. Click on some of the dropdown menus to make sure they look as expected.
  Here is the web link: https://met.readthedocs.io/en/feature_2460_dropdown_menu_appendixa/Users_Guide/appendixA.html

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

• Do these changes include sufficient testing updates? [Yes]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [4/14/2023] Date is negotiable.
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development issue with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[jprestop]

@lisagoodrich Thank your for making all of these changes! I clicked on every drop down menu and they all look great! I have a few changes to suggest, unrelated to the changes you've already made.

I'll make those inline comments to show the changes/updates I'd like you to make.

[jprestop]

@lisagoodrich in addition to all of the updates I've suggested, please change all references of BUFRLIB_v10.2.3 to BUFRLIB_v11.3.0.

Under 31.2.1. MET won’t compile, please remove the line: "Are you using NetCDF version 3.4 or version 4? Currently, only NetCDF version 3.6 can be used with MET." because that is not true.

Please add dropdown menus for the Troubleshooting section as well, however, instead of using the text "Answer" please use the text "Troubleshooting Help".

Please let me know if you have any questions.

[lisagoodrich]

@jprestop thank you for all the comments. I've made all of the changes that you requested and double checked them. Please feel free to triple check:
BUFRLIB_v10.2.3 changed to BUFRLIB_v11.3.0. (4 instances in one section.)

This line has been REMOVED: "Are you using NetCDF version 3.4 or version 4? Currently, only NetCDF version 3.6 can be used with MET." because that is not true.

I've added dropdown menus for the Troubleshooting section using the text "Troubleshooting Help". I've clicked and opened all of them.

Thanks,

Lisa

[jprestop]

@lisagoodrich Thank you for making these changes. It looks like sections 31.3. Where to get help and 31.4. How to contribute code have dropdowns for "Troubleshooting Help", but those two sections are not in the "Troubleshooting" section. Please remove the dropdown menus from those two sections.

[lisagoodrich]

@jprestop, thank you for catching that oversight. I'm hoping it's in good shape now...

[jprestop]

These changes look great! Thank you for making them. I approve this pull request.