Feature #2506 will_never_be_executed

[JohnHalleyGotway]

Expected Differences

Fix 72 SonarQube Major Bugs for code that will never be executed. These are almost always calls to return or break immediately after a call to exit(1). Note that along the way, I did remove stale commented out code when I saw it.

This should reduce the total number of major SonarQube bugs from 77 down to 5 in the nightly scan of the develop branc.

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  
  Confirmed that the code still compiles.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  Confirm that GHA runs without error.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
  None needed.

• Do these changes include sufficient testing updates? [No]
  None needed.

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Thurs 4/6/23].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development issue with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[jprestop]

I have confirmed that GitHub Actions runs without error. I approve this pull request. Thank you for all of your work on this task.

[JohnHalleyGotway]

Prior #2507 and #2505 the SonarQube findings were:

• 88 bugs and 26,046 smells

After these changes:

• 16 bugs and 25,695 smells

Differences:

• -72 bugs and -351 smells

The remaining 16 bugs are:

• 10 Blocker
• 1 Critical
• 5 Major