Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2474 sonarqube findings at MTD #2515

Merged
merged 3 commits into from
Apr 20, 2023

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Apr 20, 2023

Expected Differences

No differences except decreasing the SonarQube Findings.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

Unit test manually and compared the outputs with nightly builkd

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Code review

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [4/20/2023].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u changed the title Feature 2474 sonarqube findings MTD Feature 2474 sonarqube findings at MTD Apr 20, 2023
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the small and straightforward code changes and have ensured that all of the GitHub Actions have passed. I approve this pull request. Thank you for your continued work on SonarQube findings, @hsoh-u.

@hsoh-u hsoh-u merged commit 22fbca7 into develop Apr 20, 2023
@hsoh-u hsoh-u deleted the feature_2474_sonarqube_findings_vector branch April 20, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants