Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature main_v11.1 update install files #2586

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

jprestop
Copy link
Collaborator

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Tested new files on some new machines.  Will test on all after release and will make any updates as necessary.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    None; Review files if desired

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [None needed]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [ASAP].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone). No source issue
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number. No issue
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the MET 11.1.0 milestone Jun 27, 2023
@jprestop jprestop changed the title Updating Feature main_v11.1 update install files Jun 27, 2023
@jprestop jprestop requested a review from j-opatz June 27, 2023 16:20
Copy link
Contributor

@j-opatz j-opatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in the METplus wrappers meeting today, the errors in automated testing are unrelated to the changes of this branch.
The updates proposed by this branch fulfill their intended purpose, and the PR is approved

@jprestop jprestop merged commit 65cc39c into main_v11.1 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants