Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2615 main v11.1 gcc12 #2617

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

jprestop
Copy link
Collaborator

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    I implemented the code changes and compile with gcc 12.3.0 on my MacOS. @hsoh-u also compiled successfully with these changes.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the code changes. Ensure that all tests pass.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [20230726].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the MET 11.1.0 milestone Jul 21, 2023
@jprestop jprestop requested a review from hsoh-u July 21, 2023 15:02
@jprestop jprestop linked an issue Jul 21, 2023 that may be closed by this pull request
22 tasks
@jprestop jprestop changed the title Adding an include statement for array to allow compilation using gcc12 Feature 2615 main v11.1 gcc12 Jul 21, 2023
Copy link
Collaborator

@hsoh-u hsoh-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this at cheyenne with gnu 12.1.0.

@jprestop jprestop merged commit 6a06f18 into main_v11.1 Jul 21, 2023
33 checks passed
@jprestop jprestop deleted the feature_2615_main_v11.1_gcc12 branch August 26, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bugfix: Problem compiling MET on MacOS using GCC 12.3.0
2 participants