-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates release notes for v11.1 for function removal. #2630
Conversation
I am trying to view the docs here: https://met.readthedocs.io/en/hotfix_update_v11.1_release_notes, but it doesn't seem to be working. |
@DanielAdriaansen Only branches that begin with the following prefixes have documentation generated automatically: as listed in the GitHub Actions workflow file https://github.com/dtcenter/MET/blob/main_v11.0/.github/workflows/documentation.yml Since this branch begins with "hotfix" the documentation was not automatically generated. However, the PR generates a build of documentation, which you can see here: |
@DanielAdriaansen I added some suggestions for indention to align the code block with the bulleted list. |
Thanks @jprestop! I am happy with things now. Feel free to approve based on how the docs look here: And then merge. Appreciate your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @DanielAdriaansen! It looks good to me too. Thanks for your work on this task! I approve this request.
Closes #2624.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [Yes or No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [Yes or No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes