Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2633 seeps default p1 threshold #2634

Merged
merged 7 commits into from
Jul 31, 2023
Merged
12 changes: 7 additions & 5 deletions data/config/GridStatConfig_default
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,13 @@ distance_map = {

////////////////////////////////////////////////////////////////////////////////

//
// Threshold for SEEPS p1 (Probability of being dry)
//
seeps_p1_thresh = >=0.1&&<=0.85;

////////////////////////////////////////////////////////////////////////////////

//
// Statistical output types
// May be set separately in each "obs.field" entry
Expand Down Expand Up @@ -255,11 +262,6 @@ nc_pairs_flag = {
apply_mask = TRUE;
}

////////////////////////////////////////////////////////////////////////////////
// Threshold for SEEPS p1 (Probability of being dry)

seeps_p1_thresh = NA;

////////////////////////////////////////////////////////////////////////////////

grid_weight_flag = NONE;
Expand Down
11 changes: 7 additions & 4 deletions data/config/PointStatConfig_default
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,13 @@ hira = {

////////////////////////////////////////////////////////////////////////////////

//
// Threshold for SEEPS p1 (Probability of being dry)
//
seeps_p1_thresh = >=0.1&&<=0.85;

////////////////////////////////////////////////////////////////////////////////

//
// Statistical output types
// May be set separately in each "obs.field" entry
Expand Down Expand Up @@ -290,10 +297,6 @@ output_flag = {
seeps_mpr = NONE;
}

////////////////////////////////////////////////////////////////////////////////
// Threshold for SEEPS p1 (Probability of being dry)

seeps_p1_thresh = NA;
////////////////////////////////////////////////////////////////////////////////

tmp_dir = "/tmp";
Expand Down
8 changes: 5 additions & 3 deletions docs/Users_Guide/config_options.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1469,7 +1469,7 @@ all pairs into a single climatological bin.
direct_prob = FALSE; or TRUE
}

climato_data
climate_data
^^^^^^^^^^^^

When specifying climatology data for probability forecasts, either supply a
Expand Down Expand Up @@ -1497,13 +1497,15 @@ In this way, the number of bins impacts the resolution of the climatological
probabilities. These derived probability values are used to compute the
climatological Brier Score and Brier Skill Score.

seeps_p1_thresh
^^^^^^^^^^^^^^^

The "seeps_p1_thresh" option controls the threshold of p1 (probability of being dry) values.
The default setting is >=0.1&&<=0.85.

.. code-block:: none

seeps_p1_thresh = >=0.1&&<=0.85;

seeps_p1_thresh = >=0.1&&<=0.85;

mask_missing_flag
^^^^^^^^^^^^^^^^^
Expand Down
14 changes: 7 additions & 7 deletions docs/Users_Guide/mode.rst
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,10 @@ Traditionally, MODE defines objects by smoothing and thresholding data from a si

As described in :numref:`MODE-configuration-file`, the **field** entry in the forecast and observation dictionaries define the input data to be processed. If **field** is defined as a dictionary, the traditional method for running MODE is invoked, where objects are defined using a single input field. If **field** is defined as an array of dictionaries, each specifying a different input field, then the multi-variate MODE logic is invoked and requires the **multivar_logic** configuration entry to be set. Traditional MODE is run once for each input field to define objects for that field. Note that the object definition criteria can be defined separately for each field array entry. The objects from each input field are combined into forecast and observation data *super* objects

The **multivar_logic** and **multivar_intensity** configuration entries, described in :numref:`MODE-configuration-file`, define the boolean logic for combining objects from multiple fields into *super* objects, and then optionally computing intensities for individual input fields when the input is masked to non-missing only inside the *super* objects. If the **multivar_logic** configuration option iset, there must be the same number of fields defined in an array of dictionaries for fcst and for obs as indicated in the **multivar_logic**. Note that the multi-variate MODE forecast and observation input fields and combination logic do not need to
match. If a particular **multivar_intensity** value is TRUE the corresponding pair of fields (fcst and obs) are masked to non-missing inside the fcst and obs super objects, and traditional mode is run on that pair of masked inputs producing uniquely named outputs. If it is FALSE, mode is not run for that pair of inputs.
The **multivar_logic** and **multivar_intensity_flag** configuration entries, described in :numref:`MODE-configuration-file`, define the boolean logic for combining objects from multiple fields into *super* objects, and then optionally computing intensities for individual input fields when the input is masked to non-missing only inside the *super* objects. If the **multivar_logic** configuration option iset, there must be the same number of fields defined in an array of dictionaries for fcst and for obs as indicated in the **multivar_logic**. Note that the multi-variate MODE forecast and observation input fields and combination logic do not need to
match. If a particular **multivar_intensity_flag** value is TRUE the corresponding pair of fields (fcst and obs) are masked to non-missing inside the fcst and obs super objects, and traditional mode is run on that pair of masked inputs producing uniquely named outputs. If it is FALSE, mode is not run for that pair of inputs.

If all **multivar_intensity** values are FALSE, the forecast and observation *super* objects are written to NetCDF, text, and postscript output files in the standard mode output format, but with no intensity information.
If all **multivar_intensity_flag** values are FALSE, the forecast and observation *super* objects are written to NetCDF, text, and postscript output files in the standard mode output format, but with no intensity information.


Practical information
Expand Down Expand Up @@ -247,9 +247,9 @@ _____________________

.. code-block:: none

multivar_intensity = [FALSE, TRUE, TRUE];
multivar_intensity_flag = [FALSE, TRUE, TRUE];

The **multivar_intensity** entry appears only in the **MODEMultivarConfig_default** file. This option is paired with the **multivar_logic** entry, and can take on a value of TRUE or FALSE for each **field**. In the multivar case, super objects are created using the **multivar_logic** settings. For each input for which **multivar_intensity** is TRUE, the input is masked to be non-missing only within the super objects, and traditional mode is run on that masked input. For each input for which **multivar_intensity** is FALSE, the input is skipped over. If all the multivar_intensity values are FALSE, traditional mode output is created for the super objects, but with no intensity information.
The **multivar_intensity_flag** entry appears only in the **MODEMultivarConfig_default** file. This option is paired with the **multivar_logic** entry, and can take on a value of TRUE or FALSE for each **field**. In the multivar case, super objects are created using the **multivar_logic** settings. For each input for which **multivar_intensity_flag** is TRUE, the input is masked to be non-missing only within the super objects, and traditional mode is run on that masked input. For each input for which **multivar_intensity_flag** is FALSE, the input is skipped over. If all the multivar_intensity_flag values are FALSE, traditional mode output is created for the super objects, but with no intensity information.


_____________________
Expand All @@ -258,7 +258,7 @@ _____________________

multivar_name = "Precip";

The **multivar_name** entry appears only in the **MODEMultivarConfig_default** file. This option is used only when the multivar option is enabled, and only when all **multivar_intensity** flag values are FALSE. It can be thought of as an identifier for the multivariate super object. It shows up in output files names and content. If not set the default value is "Super". It can be set separately for forecasts and observations, or as a common value for both.
The **multivar_name** entry appears only in the **MODEMultivarConfig_default** file. This option is used only when the multivar option is enabled, and only when all **multivar_intensity_flag** values are FALSE. It can be thought of as an identifier for the multivariate super object. It shows up in output files names and content. If not set the default value is "Super". It can be set separately for forecasts and observations, or as a common value for both.


_____________________
Expand All @@ -267,7 +267,7 @@ _____________________

multivar_level = "LO";

The **multivar_level** entry appears only in the **MODEMultivarConfig_default** file. This option is used only when the multivar option is enabled, and only when all **multivar_intensity** flag values are FALSE. It is the identifier for the multivariate super object as regards level. It shows up in output files names and content. If not set the default value is "NA". It can be set separately for forecasts and observations, or as a common value for both.
The **multivar_level** entry appears only in the **MODEMultivarConfig_default** file. This option is used only when the multivar option is enabled, and only when all **multivar_intensity_flag** values are FALSE. It is the identifier for the multivariate super object as regards level. It shows up in output files names and content. If not set the default value is "NA". It can be set separately for forecasts and observations, or as a common value for both.

_____________________

Expand Down
12 changes: 7 additions & 5 deletions internal/test_unit/xml/unit_plot_tc.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,15 @@
-lookin &OUTPUT_DIR;/tc_pairs/alal2010.tcst \
-filter '-amodel AHWI,BCLP' \
-outdir &OUTPUT_DIR;/plot_tc \
-dep 'TK_ERR,ABS(AMAX_WIND-BMAX_WIND)'
-dep 'TK_ERR,ABS(AMAX_WIND-BMAX_WIND)' \
-save_data &OUTPUT_DIR;/plot_tc/plot_tc_TCMPR_data.tcst
</param>
<output>
<exist>&OUTPUT_DIR;/plot_tc/ABS_AMAX_WIND-BMAX_WIND_boxplot.png</exist>
<exist>&OUTPUT_DIR;/plot_tc/ABS_AMAX_WIND-BMAX_WIND_boxplot.log</exist>
<exist>&OUTPUT_DIR;/plot_tc/TK_ERR_boxplot.png</exist>
<exist>&OUTPUT_DIR;/plot_tc/TK_ERR_boxplot.log</exist>
<exist>&OUTPUT_DIR;/plot_tc/ABS_AMAX_WIND-BMAX_WIND_boxplot.png</exist>
<exist>&OUTPUT_DIR;/plot_tc/ABS_AMAX_WIND-BMAX_WIND_boxplot.log</exist>
<exist>&OUTPUT_DIR;/plot_tc/TK_ERR_boxplot.png</exist>
<exist>&OUTPUT_DIR;/plot_tc/TK_ERR_boxplot.log</exist>
<stat>&OUTPUT_DIR;/plot_tc/plot_tc_TCMPR_data.tcst</stat>
</output>
</test>

Expand Down