Feature 2640 ioda2nc dimension

[hsoh-u]

Expected Differences

ioda2nc processes the IODA input with Location dimension instead of nlocs dimension.

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  

/d1/personal/hsoh/git/pull_request/MET_feature_2640_ioda2nc_dimension/bin/ioda2nc /d1/personal/hsoh/data/IODA_files/avhrr_radiance_location.nc met_avhrr_radiance_location.nc /d1/personal/hsoh/git/pull_request/MET_feature_2640_ioda2nc_dimension/share/met/config/IODA2NCConfig -v 3 -obs_var brightness_temperature

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

If you have IODAS V3 data file (with nlocs dimension), make a IODA file with Location dimension.

ncdump IODAV3_filename > IODAV3_filename.dump
sed -i -e "s|nlocs|Location|g" IODAV3_filename.dump
ncgen -o IODAV3_filename.Location.nc IODAV3_filename.dump

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

• Do these changes include sufficient testing updates? [No]

• Will this PR result in changes to the test suite? [no]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the version that will include these changes
  Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[jprestop]

HI @hsoh-u. Can you please confirm that these are expected differences (from the failing test)?

COMPARING ioda2nc/odb_sonde_16019_all.nc
file1: /data/output/met_test_truth/ioda2nc/odb_sonde_16019_all.nc
file2: /data/output/met_test_output/ioda2nc/odb_sonde_16019_all.nc
ERROR: NetCDF headers differ:
6c6
< 	nhdr = 2 ;
---
> 	nhdr = 96 ;
8,9c8,9
< 	nhdr_typ = 1 ;
< 	nhdr_sid = 1 ;
---
> 	nhdr_typ = 23 ;
> 	nhdr_sid = 20 ;

End of script
ERROR: Differences exist in the output
Error: Process completed with exit code 1.

[hsoh-u]

I did not expect differences. I will take a look.

[hsoh-u]

Ready for review

[jprestop]

I do not have an IODAS V3 data file and am relying on the testing by @hsoh-u. I have reviewed the code changes and have ensured that all tests passed. I approve this request.