Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2724 mode_openmp #2726

Merged
merged 13 commits into from
Nov 7, 2023
Merged

Commits on Nov 2, 2023

  1. Configuration menu
    Copy the full SHA
    ba5cc6e View commit details
    Browse the repository at this point in the history
  2. Per #2574, remove bad_data_double from the list of shared variables s…

    …ince its declared as const. The GNU compiler on seneca errors out when constants are included in the shared list while the GNU compiler on my Mac laptop doesn't complain.
    JohnHalleyGotway committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5d5cf19 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Per #2724, eliminate unnecessary memory allocation of a new ShapeData…

    … object for each field. Still more work to do to reduce memory usage and also apply OpenMP to the ShapeData::select() function.
    JohnHalleyGotway committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    22de88f View commit details
    Browse the repository at this point in the history
  2. Per #2724, refining the implementation of ShapeData::conv_filter_circ…

    …() to exactly reproduce existing results. There were some subtle diffs in the handling of missing data and points off the grid.
    JohnHalleyGotway committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    042bf4f View commit details
    Browse the repository at this point in the history
  3. Per #2724, revert back the premature changes in engine.cc. There is l…

    …ikely a way to make the memory usage for efficient but it'll require a tweak to the logic.
    JohnHalleyGotway committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    5bdf1bd View commit details
    Browse the repository at this point in the history
  4. Per #2574, update the mode engine to store a pointer to the split fie…

    …ld rather than the individual object fields. And compute pair intersection, union, and sym diff counts from the split field rather than the object fields. This avoid allocating memory for many, many copies of the input grid, which can be quite large depending on the resolution.
    JohnHalleyGotway committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    6547387 View commit details
    Browse the repository at this point in the history
  5. Per #2724, update ModeFuzzyEngine::do_cluster_features() to avoid mem…

    …ory allocation for ShapeData objects.
    JohnHalleyGotway committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    f297e29 View commit details
    Browse the repository at this point in the history
  6. Per #2724, OpenMP was added when both ensemble-stat and gen-ens-prod …

    …were computing NMEP outputs. That was removed from ensemble-stat in MET version 11.1 but the OpenMP setup remained there. This removes it from ensemble-stat and updates the documentation to accurately indicate that OpenMP currently applies to gen-ens-prod, grid-stat, and now mode.
    JohnHalleyGotway committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    880851a View commit details
    Browse the repository at this point in the history
  7. Per #2724, swap in new logic for the double-thresholding check that s…

    …hould be faster and use much less memory.
    JohnHalleyGotway committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    ff5e08c View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Per #2724, refine DataPlane debug_examine() and sdebug_examine() funt…

    …ions to be more efficient by accessing the vector of data rather than the slower get(x,y) data accessor function.
    JohnHalleyGotway committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    1085c85 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aa80374 View commit details
    Browse the repository at this point in the history
  3. Per #2724, wrap each call to sdebug_examine() with a check of the ver…

    …bosity level to avoid unnecessary loops through the data. Note that all calls to the logger would actually create the log message and the logger decides whether or not to print it. Wrapping expensive debugging log messages in vebosity level check is more efficient.
    JohnHalleyGotway committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    93f50ce View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Per #2724, make the computation of union, intersection, and symmetric…

    … diff a bit more efficient by accessing the data() array directly rather than range-checking with the data(x,y) accessor function.
    JohnHalleyGotway committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    fa9ea77 View commit details
    Browse the repository at this point in the history