Feature #2611 oneapi met-basev3.1 #2737
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
This PR updates the develop branch to add:
compile_MET_all.sh
Switch from using
met-base:v3.0
tomet-base:v3.1
.compile_MET_all.sh
script in this feature branch to actually build. And this branch switches to using METbaseimage v3.1. To handle this, I've manually pushed a temporary version ofdtcenter/met-base:v3.1
to DockerHub but it will be replaced by the official release.Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Lots of manual testing in Docker by @jprestop and @JohnHalleyGotway.
To address the circular dependency described above, I manually built the
dtcenter/met-base:v3.1
Docker image as follows:And with that version of METbaseimage, the code for this PR compiles successfully.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
None really.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
No documentation updates.
Do these changes include sufficient testing updates? [No]
No additional unit tests are needed.
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
This should produce the same unit test output.
Please complete this pull request review by [Tues 11/14/23].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases