Feature 2673 sonarqube beta2

[hsoh-u]

Reduce the bugs (9 to 5)
Scan result

• Bugs:: nc_utils.cc initialized the variables.

• Code Smell: pcp_combin.cc, nc_utils.hh:

  • 0 is replaced to nullptr,
  • "return (var);" was changed to m"return var;" (Remove these redundant parentheses)

Note: bugs were not reduced with wchar_argv.cc, but no harms with initializing them.

Expected Differences

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  

unit test and the same results

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

NA

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

• Do these changes include sufficient testing updates? [No]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [11/17].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the version that will include these changes
  Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[jprestop]

I have reviewed the code changes and ensured that all tests passed. Thanks for all of your work on this task @hsoh-u! I approve this request.

[JohnHalleyGotway]

I am proceeding with merging these changes. @hsoh-u thanks for the work, and @jprestop thanks for the review.

I note that I WILL NOT actually close issue #2673, since the SonarQube work will continue in future beta releases. But I will include it in the beta2 release notes and also move it to beta3.