Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2757 sonarqube token #2765

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Feature #2757 sonarqube token #2765

merged 3 commits into from
Dec 14, 2023

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Dec 13, 2023

Expected Differences

The sonar-project.properies files are templates. The SonarQube server URL and token are replaced with the pre-defined strings, SONAR_SERVER_URL and SONAR_TOKEN_VALUE. run_sonarqubue.sh replaces them from the same environment variables. The email list from the environment variable MET_CRON_EMAIL_LIST_MET replaces the default email list.

At seneca, they are defined at ~/config/met_env.sh under met_test account.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

N/A. Deployed at the seneca under met_test account for the nightly build

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

N/A

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Howard Soh added 3 commits December 13, 2023 20:45
…ent variable SONAR_TOKEN_VALUE and SONAR_SERVER_URL
…trings, SONAR_TOKEN_VALUE and SONAR_SERVER_URL
@hsoh-u hsoh-u added this to the MET 12.0.0 milestone Dec 13, 2023
@hsoh-u hsoh-u requested a review from jprestop December 13, 2023 21:21
@hsoh-u hsoh-u linked an issue Dec 13, 2023 that may be closed by this pull request
22 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this task, @hsoh-u. I have reviewed the code changes and ensure that all tests passed. I approve this request.

@hsoh-u hsoh-u merged commit c8e4a17 into develop Dec 14, 2023
35 checks passed
@hsoh-u hsoh-u deleted the feature_2757_SonarQube_token branch December 14, 2023 17:10
@JohnHalleyGotway JohnHalleyGotway changed the title Feature 2757 sonar qube token Feature #2757 sonarqube token Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Remove the SonarQube token from the properties file
2 participants