Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2673 sonarqube beta4 return #2828

Merged
merged 7 commits into from
Feb 28, 2024

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Feb 28, 2024

Expected Differences

No differences except changes in the source code. SonarQube suggests to remove the redundant parentheses with return statement return ( true ); to return true; (identified as a code smells)

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

ran unit test and check the output
SonarQube scanning result: & click "Overall Code" instead of "New Code"

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u added this to the MET 12.0.0 milestone Feb 28, 2024
@hsoh-u hsoh-u requested a review from jprestop February 28, 2024 16:06
@hsoh-u hsoh-u linked an issue Feb 28, 2024 that may be closed by this pull request
21 tasks
@hsoh-u hsoh-u changed the title Feature 2673 sonarqube beta3 return Feature 2673 sonarqube beta4 return Feb 28, 2024
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsoh-u Thank you again so much for all of your work on this! I approve this pull request.

@hsoh-u hsoh-u merged commit 00b162b into develop Feb 28, 2024
37 checks passed
@hsoh-u hsoh-u deleted the feature_2673_sonarqube_beta3_return branch April 5, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Fix the SonarQube findings for MET version 12.0.0
2 participants