Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2673 Changed literal 1 to the boolean value, true #2832

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Mar 7, 2024

Expected Differences

At the source codes: literal 1 is changed to the boolean value true with while statement

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

unittest and GHA

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

N/A

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u added this to the MET 12.0.0 milestone Mar 7, 2024
@hsoh-u hsoh-u requested a review from jprestop March 7, 2024 15:40
@hsoh-u hsoh-u linked an issue Mar 7, 2024 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsoh-u Thank you for your work on this task and for running the unit tests. I see that all GHA tests have passed as well. I approve this PR.

@hsoh-u hsoh-u merged commit 4d7d4a2 into develop Mar 7, 2024
60 checks passed
@hsoh-u hsoh-u deleted the feature_2673_sonarqube_1_to_true branch March 7, 2024 16:27
@hsoh-u hsoh-u restored the feature_2673_sonarqube_1_to_true branch March 7, 2024 16:27
@JohnHalleyGotway JohnHalleyGotway changed the title #2673 Changed literal 1 to the boolean value, true Feature 2673 Changed literal 1 to the boolean value, true Mar 13, 2024
@hsoh-u hsoh-u deleted the feature_2673_sonarqube_1_to_true branch April 5, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Fix the SonarQube findings for MET version 12.0.0
2 participants