Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix #2833 develop azimuth #2840

Merged
merged 11 commits into from
Mar 27, 2024
Merged

Bugfix #2833 develop azimuth #2840

merged 11 commits into from
Mar 27, 2024

Commits on Mar 7, 2024

  1. Per #2833, fix n-1 bug when defining the azimuth delta for range/azim… 

    …uth grids.
    @JohnHalleyGotway
    JohnHalleyGotway committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    afd886a View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Per #2833, when definng TcrmwData:range_max_km, divide by n_range - 1… 

    … since the range values start at 0.
    @JohnHalleyGotway
    JohnHalleyGotway committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    18ace77 View commit details
    Browse the repository at this point in the history

  2. Per #2833, remove max_range_km from the TC-RMW config file. Set the d… 

    …efault rmw_scale to NA so that its not used by default. And update the documentation. Still actually need to make the logic of the code work as it should.
    @JohnHalleyGotway
    JohnHalleyGotway committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    ef68b17 View commit details
    Browse the repository at this point in the history

  3. Per #2833, update tc_rmw to define the range as either a function of … 

    …rmw or using explicit spacing in km.
    @JohnHalleyGotway
    JohnHalleyGotway committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    18f17d5 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Per #2833, update the TCRMW Config files to remove the max_range_km e… 

    …ntry, and update the unit test for one call to use RMW ranges and the other to use ranges defined in kilometers.
    @JohnHalleyGotway
    JohnHalleyGotway committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    a502ea0 View commit details
    Browse the repository at this point in the history

  2. Per #2833, just correct code comments.

    @JohnHalleyGotway
    JohnHalleyGotway committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    76ea20e View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Per #2833, divide by n - 1 when computing the range delta, rather tha… 

    …n n.
    MET Tools Test Account committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f678ad2 View commit details
    Browse the repository at this point in the history

  2. Per #2833, correct the handling of the maximum range in the tc-rmw to… 

    …ol. For fixed delta km, need to define the max range when setting up the grid at the beginning.
    MET Tools Test Account committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    6feb5a4 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Merge remote-tracking branch 'origin/develop' into bugfix_2833_develo… 

    …p_azimuth
    MET Tools Test Account committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    b25b2e8 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into bugfix_2833_develo… 

    …p_azimuth
    MET Tools Test Account committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    2c570cc View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/develop' into bugfix_2833_develo… 

    …p_azimuth
    MET Tools Test Account committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    9b38a8a View commit details
    Browse the repository at this point in the history