Bugfix #2856 main_v11.1 ens_climo

[JohnHalleyGotway]

Expected Differences

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  
  Please see seneca:/d1/projects/METplus/discussions/2536/es_example

Run ./run_es_v11.1.0.sh to run Ensemble-Stat for version 11.1.0 and generate the following error mesage:

ERROR  : NumArray::operator[](int) const -> range check error ... Length = 0, i = 0

Note that this is fixed by changes in ensemble_stat.cc. But it triggered another runtime error when writing .stat output lines:

ERROR  :   AsciiTable::rc_to_n() -> range check error ... 
ERROR  :                            (Nrows, Ncols) = (243, 66)
ERROR  :                            (r, c) = (243, 0)

This is fixed by changes in ensemble_stat_conf_info.cc by reserving additional space in the output AsciiTable by multiplying by extra dimensions when determining the maximum number of output lines.

I found that many instances of nan were written to the output for empty contingency tables. These are replaced with NA by the changes to the vx_statistics and vx_stat_out libraries.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  Review code changes. Could re-do the testing on seneca to confirm results, if needed.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
  None needed.

• Do these changes include sufficient testing updates? [No]
  I should consider adding tests to develop, not main_v11.1.

• Will this PR result in changes to the MET test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Will this PR result in changes to existing METplus Use Cases? [No]
  
  If yes, create a new Update Truth METplus issue to describe them.

• Do these changes introduce new SonarQube findings? [No]
  
  If yes, please describe:

• Please complete this pull request review by [Thurs 6/20/24].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the version that will include these changes
  Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[j-opatz]

This is largely a programming change, but reading through the Discussions that led to this PR shows the scientific applications of this update. Probabilistic forecasts can be evaluated without a climatology, and the only affected statistic in the PSTD line type I see would be BSS (need a climo to calculate the skill score).

The same bugfix for the develop branch adds a unit test for this function, covering any unseen issues that may occur with future applications that DO provide climo data.

Hopefully we can have the original bug-finder test this fix out and confirm that the results are as they intended.