Code

Feature #2279 point_weight_flag#2993

Code

Merged

JohnHalleyGotway merged 56 commits intodevelopdtcenter/MET:developfrom feature_2279_point_weight_flagdtcenter/MET:feature_2279_point_weight_flagCopy head branch name to clipboardOct 16, 2024

+3,848-550

Commits

Commits on Aug 28, 2024

• Per #2887, update NumArray::vals() to return a reference to the vector rather a pointer to doubles.

  JohnHalleyGotway

  committed
  09f802e

  Copy full SHA for 09f802e

• Per #2887, switch over the whole ContingencyTable class heirarchy from storing integer counts to storing double-precision weights.

  JohnHalleyGotway

  committed
  38a5d4e

  Copy full SHA for 38a5d4e

• Add ContingencyTable::is_integer() member function to check whether the table contains all integers

  JohnHalleyGotway

  committed
  5e1d81d

  Copy full SHA for 5e1d81d

• Per #2887, update parse_stat_line.cc to get it to compile after changing PCT to store thresholds in a std::vector.

  JohnHalleyGotway

  committed
  32f3601

  Copy full SHA for 32f3601

• Per #2887, update PCTInfo::clear() logic.

  JohnHalleyGotway

  committed
  5834afd

  Copy full SHA for 5834afd

Commits on Sep 3, 2024

• Merge remote-tracking branch 'origin/develop' into feature_2887_categorical_weights

  JohnHalleyGotway

  committed
  f2a1fd0

  Copy full SHA for f2a1fd0

• Per #2887, update ctc_by_row() logic to create reproducible results with the develop branch.

  JohnHalleyGotway

  committed
  8c629e6

  Copy full SHA for 8c629e6

• Per #2887, update logic of define_prob_bins() to add a final >=1.0 threshold if needed. While ==0.1 works fine, I found that ==0.05 did not because the last >=1.0 threshold was missing likely do to…

  Show description for b98276a
  JohnHalleyGotway

  committed
  b98276a

  Copy full SHA for b98276a

• Per #2887, update roc_auc() function to match the develop branch

  JohnHalleyGotway

  committed
  dacd1d2

  Copy full SHA for dacd1d2

• Per #2887, fix bug if computation of far()

  JohnHalleyGotway

  committed
  a5403e2

  Copy full SHA for a5403e2

Commits on Sep 4, 2024

• Per #2887, replaced all ==0 integer equality checks with calls to is_eq() instead and fix a couple of equations to snuff out diffs in some CTS statistics.

  JohnHalleyGotway

  committed
  2a68914

  Copy full SHA for 2a68914

Commits on Sep 6, 2024

• Merge remote-tracking branch 'origin/develop' into feature_2887_categorical_weights

  JohnHalleyGotway

  committed
  1b8cd06

  Copy full SHA for 1b8cd06

Commits on Sep 9, 2024

• Per #2887, address some of the 34 SonarQube code smells flagged for this PR. Note that the compute_ci.h/.cc changes are necessary and good since we should be computing CI's using doubles instead of…

  Show description for 7bce8b8
  JohnHalleyGotway

  committed
  7bce8b8

  Copy full SHA for 7bce8b8

• Per #2887, update run_sonarqube.sh to specify the target CXX standard as 11. The hope is that that will limit the findings to only those features available in the C++11 standard.

  JohnHalleyGotway

  committed
  f0395b0

  Copy full SHA for f0395b0

• Per #2887, update to SonarQube version 6.1.0.4477 released on 6/27/2024.

  JohnHalleyGotway

  committed
  8e1ecef

  Copy full SHA for 8e1ecef

• Per #2887, updating build_met_sonarqube.sh to specify --std=c++11 since c++17 is used by default

  JohnHalleyGotway

  committed
  1144765

  Copy full SHA for 1144765

Commits on Sep 10, 2024

• Merge remote-tracking branch 'origin/develop' into feature_2887_categorical_weights

  JohnHalleyGotway

  committed
  29673cf

  Copy full SHA for 29673cf

• Per #2887, swap in a much simpler implementation of the ORSS statistic to match the equation listed in the MET User's Guide.

  JohnHalleyGotway

  committed
  1548c75

  Copy full SHA for 1548c75

Commits on Oct 3, 2024

• Merge remote-tracking branch 'origin/develop' into feature_2887_categorical_weights

  JohnHalleyGotway

  committed
  ec99867

  Copy full SHA for ec99867

• Merge remote-tracking branch 'origin/develop' into feature_2887_categorical_weights

  JohnHalleyGotway

  committed
  210eab2

  Copy full SHA for 210eab2

• Per #2887, update grid_stat and library code to actually apply the grid_weight_flag settings to the computation of contingency table counts and statistics.

  JohnHalleyGotway

  committed
  33ddd51

  Copy full SHA for 33ddd51

Commits on Oct 4, 2024

• Per #2887, fix the handling of bad data in the ORSS equation.

  JohnHalleyGotway

  committed
  97cfbfa

  Copy full SHA for 97cfbfa

• Per #2887, add Npairs member to the ContingencyTable class, eliminate the n() accessor function, and carefully replace references to n() with n_pairs() for the integer number of matched pairs or to…

  Show description for 17dc1b7
  JohnHalleyGotway

  committed
  17dc1b7

  Copy full SHA for 17dc1b7

Commits on Oct 7, 2024

• Per #2887, reset Npairs = 0 for ContingencyTable::zero_out()

  JohnHalleyGotway

  committed
  ace7c1b

  Copy full SHA for ace7c1b

• Per #2883, need to call set_n_pairs() in a few spots to set ECLV TOTAL column correctly ci-run-unit

  JohnHalleyGotway

  committed
  55dbd06

  Copy full SHA for 55dbd06

• Per #2887, call set_n_pairs() when aggregating PCT data in Series-Analysis ci-run-unit

  JohnHalleyGotway

  committed
  e44a100

  Copy full SHA for e44a100

• Per #2887, update stat_analysis to parse the TOTAL column for the PCT and MCTC line types.

  JohnHalleyGotway

  committed
  8e3e6c7

  Copy full SHA for 8e3e6c7

• Pet #2882, call set_n_pairs() after set_size() ci-run-unit

  JohnHalleyGotway

  committed
  d1772df

  Copy full SHA for d1772df

Commits on Oct 8, 2024

• Per #2887, reconfigure existing Ensemble-Stat unit test to request probabilistic output to see that it's impacted by the grid_weight_flag setting.

  JohnHalleyGotway

  committed
  1bd61df

  Copy full SHA for 1bd61df

• Per #2887, update Ensemble-Stat test to provide climo stdev data

  JohnHalleyGotway

  committed
  88a8c22

  Copy full SHA for 88a8c22

• Per #2887, add grid_weight_flag to the list of config options for Grid-Stat and Ensemble-Stat.

  JohnHalleyGotway

  committed
  7b9ab8c

  Copy full SHA for 7b9ab8c

• Per #2887, disable FHO output if grid_weight_flag != NONE.

  JohnHalleyGotway

  committed
  2ec2e22

  Copy full SHA for 2ec2e22

• Per #2887, revise the existing unit_grid_weight.xml unit tests for Grid-Stat to write CTC/CTS/MCTC/MCTS output and for the DESC column to be populated to indicate the type of grid weighting that wa…

  Show description for 940c9e2
  JohnHalleyGotway

  committed
  940c9e2

  Copy full SHA for 940c9e2

Commits on Oct 9, 2024

• Merge remote-tracking branch 'origin/develop' into feature_2279_point_weight_flag

  JohnHalleyGotway

  committed
  9e4f00f

  Copy full SHA for 9e4f00f

• Per #2279, add the MaskSID struct to store information about station id names and corresponding weights.

  JohnHalleyGotway

  committed
  4bbe2ae

  Copy full SHA for 4bbe2ae

• Per #2279, add new PointWeightType enumeration along with code to parse it.

  JohnHalleyGotway

  committed
  d3069d0

  Copy full SHA for d3069d0

Commits on Oct 10, 2024

• Per #2279, adding point_weight_flag option to all Point-Stat and Ensemble-Stat config file and tweaking whitespace.

  JohnHalleyGotway

  committed
  f5f4d99

  Copy full SHA for f5f4d99

• Per #2279, add point_weight_flag to the Point-Stat and Ensemble-Stat config class. Also remove sue unneeded wgt_dp argument for the add_point_obs() functions. Plan to add logic to set the point wei…

  Show description for d520fef
  JohnHalleyGotway

  committed
  d520fef

  Copy full SHA for d520fef

• Per #2279, use the default_weight contstant instead of the literal 1.0 value.

  JohnHalleyGotway

  committed
  b2ed2a6

  Copy full SHA for b2ed2a6

• Per #2279, add stubs for actually applying the point_weight_flag settings.

  JohnHalleyGotway

  committed
  0edcd65

  Copy full SHA for 0edcd65

• Per #2279, fix PairBase to actually set point weight values parsed from station id masks.

  JohnHalleyGotway

  committed
  d5a26b5

  Copy full SHA for d5a26b5

• Per #2279, trying to fix 2 sonarqurqube bugs

  JohnHalleyGotway

  committed
  9806e0a

  Copy full SHA for 9806e0a

Commits on Oct 11, 2024

• Per #2279, fix a couple bugs parsing the SID weights and add a new unit_point_weight.xml unit test to run Point-Stat on scalar and probability inputs weighting the stations by their elevation. Stil…

  Show description for eabaaaf
  JohnHalleyGotway

  committed
  eabaaaf

  Copy full SHA for eabaaaf

• Per #2279, fix small bug ci-run-unit

  JohnHalleyGotway

  committed
  5723b18

  Copy full SHA for 5723b18

• Per #2279, add ensemble_stat calls to unit_point_weight.xml

  JohnHalleyGotway

  committed
  3beab1f

  Copy full SHA for 3beab1f

• Merge remote-tracking branch 'origin/develop' into feature_2279_point_weight_flag ci-run-unit

  JohnHalleyGotway

  committed
  764164b

  Copy full SHA for 764164b

• Merge remote-tracking branch 'origin/develop' into feature_2279_point_weight_flag

  JohnHalleyGotway

  committed
  25ca869

  Copy full SHA for 25ca869

• Per #2279, add documentation about the point_weight_flag configuration option.

  JohnHalleyGotway

  committed
  a0c1dc4

  Copy full SHA for a0c1dc4

• Per #2279, working on debug and warning messages.

  JohnHalleyGotway

  committed
  b086ae0

  Copy full SHA for b086ae0

Commits on Oct 14, 2024

• Merge remote-tracking branch 'origin/develop' into feature_2279_point_weight_flag

  JohnHalleyGotway

  committed
  458c6df

  Copy full SHA for 458c6df

• Per #2279, tweak the user's guide

  JohnHalleyGotway

  committed
  13fe94a

  Copy full SHA for 13fe94a

• Per #2279, switch MaskSID::sid_list from a vector of pairs to a simpler map named sid_map.

  JohnHalleyGotway

  committed
  02302be

  Copy full SHA for 02302be

• Per #2279, fix the madis2nc call to parse_sid_mask()

  JohnHalleyGotway

  committed
  40e805b

  Copy full SHA for 40e805b

Commits on Oct 15, 2024

• Per #2279, move MaskSID from vx_config over into dedicated vx_util/mask_sid.h and .cc to be consistent with mask_poly.h. I note that the members of the MaskSID struct were not being initialized pro…

  Show description for 39b60f3
  JohnHalleyGotway

  committed
  39b60f3

  Copy full SHA for 39b60f3

• Per #2279, another change to make it compile.

  JohnHalleyGotway

  committed
  cf13262

  Copy full SHA for cf13262

• Per #2279, more tweaks to get it to compile.

  JohnHalleyGotway

  committed
  9ecea77

  Copy full SHA for 9ecea77