Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance METbaseimage to compile the ecKit and Atlas libraries #13

Closed
7 of 21 tasks
JohnHalleyGotway opened this issue Aug 28, 2023 · 0 comments · Fixed by #17
Closed
7 of 21 tasks

Enhance METbaseimage to compile the ecKit and Atlas libraries #13

JohnHalleyGotway opened this issue Aug 28, 2023 · 0 comments · Fixed by #17
Assignees
Labels
priority: blocker Blocker requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Aug 28, 2023

Describe the Enhancement

dtcenter/MET#2574 adds new dependencies on the ecKit and Atlas libraries.

After the MET compile_MET_all.sh script and corresponding tar files have been updated to compile both the ecKit and Atlas libraries, create a new METbaseimage tag to provide a new version on DockerHub. This will facilitate MET development that links against these new libraries.

Time Estimate

1 hour.
Most of the work is updating the MET repo. All we really need to do here is create a new tag to trigger GHA to recreate the base images.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2702691

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added alert: NEED ACCOUNT KEY Need to assign an account key to this issue priority: blocker Blocker requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing labels Aug 28, 2023
@JohnHalleyGotway JohnHalleyGotway self-assigned this Aug 28, 2023
@jprestop jprestop removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Nov 6, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the METbaseimage 3.1 milestone Nov 7, 2023
jprestop added a commit that referenced this issue Nov 9, 2023
@jprestop jprestop linked a pull request Nov 10, 2023 that will close this issue
13 tasks
@JohnHalleyGotway JohnHalleyGotway changed the title Update METbaseimage to compile the ecKit and Atlas libraries Enhance METbaseimage to compile the ecKit and Atlas libraries Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: blocker Blocker requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

2 participants