Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calculation of the Scatter Index statistic #108 #110

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

TatianaBurek
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:
    Tested using UI on dakota and compared with Rscript results

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
    XML to test
    plot_20210817_124037.xml.txt

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@TatianaBurek TatianaBurek added this to the METcalcpy-1.1 milestone Aug 17, 2021
@TatianaBurek TatianaBurek requested a review from bikegeek August 17, 2021 18:47
@TatianaBurek TatianaBurek linked an issue Aug 17, 2021 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@bikegeek bikegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully re-created expected plot in METviewer

@TatianaBurek TatianaBurek merged commit 16e27b8 into develop Aug 17, 2021
@TatianaBurek TatianaBurek deleted the issue/108-si_stat branch August 17, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add calculation of the Scatter Index statistic
2 participants