Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
updated METviewer development version on 'dakota' to use the changes made in METcalcpy for calculating the OBJCSI and OBJACSI (equations are consistent with the METviewer documentation and in the agg_stat_bootstrap.R code in METviewer)
loaded the XML config file from the test used to test the METviewer changes in issue #561:
plot_20240215_190637.xml.txt
From changes made to Rscript (METviewer issue #561):
plot_20240215_190637.points1.txt
From changes made to the METcalcpy equations:
R-script generated plot:
Python script generated plot (i.e. with METcalcpy equation updates)
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
create any additional MODE CSI plots on the METviewer instance on 'dakota' and verify that the trends for the OBJCSI and OBJACSI plots are consistent with expected behavior.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]
Do these changes include sufficient testing updates? [No]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by Earliest convenience.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METcalcpy-X.Y.Z Development project for official releases