Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide instructions for updating the database schema corresponding to any MET updates #245

Closed
23 tasks
bikegeek opened this issue Nov 15, 2023 · 1 comment · Fixed by #275
Closed
23 tasks
Assignees
Labels
component: documentation Documentation issue component: METdataio component: user support User support issue METdataio: Load Tropical Cyclone Data priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: Community General Community requestor: CSU/CIRA Colorado State University, Cooperative Institute for Research in the Atmosphere requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work

Comments

@bikegeek
Copy link
Collaborator

bikegeek commented Nov 15, 2023

Describe the Task

Include instructions for updating the database schema whenever there is an update to the MET linetypes and/or whenever a new version of MET is available. This work needs to be done retrospectively for 5.1 as well as for the 6.0.0-beta3 releases.

This task needs to be done for every release. Incorporate this in the METdataio

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the task down into sub-issues.

  • Commit the update scripts for the 5.1 release
  • Update the Release Guide to include updates to the sql update script

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@bikegeek bikegeek added alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required priority: high High Priority type: task An actionable item of work alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle component: documentation Documentation issue component: user support User support issue reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: Community General Community requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project METdataio: Load Tropical Cyclone Data component: METdataio requestor: CSU/CIRA Colorado State University, Cooperative Institute for Research in the Atmosphere labels Nov 15, 2023
@bikegeek bikegeek added this to the METdataio-3.0.0 milestone Nov 15, 2023
@bikegeek bikegeek self-assigned this Nov 15, 2023
@jprestop jprestop removed the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Dec 8, 2023
@bikegeek bikegeek removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required labels Feb 6, 2024
@bikegeek
Copy link
Collaborator Author

bikegeek commented Feb 6, 2024

Thankfully, @TatianaBurek shared her steps:

I don't have any notes but here are the steps what I do:

  1. create a file in update_for_<version_number>.sql in /METdbLoad/sql/updates/update_for_5_1.sql
  2. in this file implement all needed schema changes that have to be performed on existing databases
  3. made changes in /METdbLoad/sql/mv_mysql.sql to reflect the latest changes in the schema
  4. inform users (release notes???) that the schema changes were made and they need to run update_for_<version_number>.sql script on all their databases

bikegeek added a commit that referenced this issue Feb 6, 2024
bikegeek added a commit that referenced this issue Feb 6, 2024
bikegeek added a commit that referenced this issue Feb 6, 2024
bikegeek added a commit that referenced this issue Feb 7, 2024
#275)

* Issue #245 Contributor's Guide with instructions on updating the database schema

* Issue #245 Add the Contributor's Guide

* Issue #245 Additional information on creating the Github issue and closing after approval

* Issue #245 more instructions on filling out the issues template

* Issue #245 correct grammatical error

* issue #245 edits based on comments from first pass of PR

* Issue #245 added instructions for the mv_mysql.sql file
@bikegeek bikegeek moved this from 🔖 Ready to 👀 In review in METplus-Analysis-6.0.0 Development Feb 7, 2024
@bikegeek bikegeek moved this from 👀 In review to ✅ Done in METplus-Analysis-6.0.0 Development Feb 7, 2024
@bikegeek bikegeek moved this from 🔖 Ready to ✅ Done in Coordinated METplus-5.1 Support Feb 7, 2024
@bikegeek bikegeek closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Documentation issue component: METdataio component: user support User support issue METdataio: Load Tropical Cyclone Data priority: high High Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: Community General Community requestor: CSU/CIRA Colorado State University, Cooperative Institute for Research in the Atmosphere requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

2 participants