-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide reformatting for the DMAP line type and any associated plots #348
Labels
component: METdataio
METdataio: General
priority: high
High Priority
reporting: NRL METplus
Naval Research Laboratory METplus Project
requestor: Navy/NRL
Naval Research Laboratory
type: enhancement
Improve something that it is currently doing
Milestone
Comments
bikegeek
added
type: enhancement
Improve something that it is currently doing
priority: high
High Priority
requestor: Navy/NRL
Naval Research Laboratory
METdataio: General
component: METdataio
reporting: NRL METplus
Naval Research Laboratory METplus Project
labels
Oct 25, 2024
github-project-automation
bot
moved this to 🟢 Ready
in METplus-Analysis-6.1.0 Development
Oct 25, 2024
bikegeek
changed the title
Provide reformatting for the DLAND land type and any associated plots
Provide reformatting for the DMAP land type and any associated plots
Oct 25, 2024
bikegeek
moved this from 🟢 Ready
to 🏗 In progress
in METplus-Analysis-6.1.0 Development
Oct 31, 2024
Identified scatter, line, and contour plots as plots to support use of this linetype. The refactored scatter plot developed for the Land project will be the version to use, as the current scatter plot is out-of-date and defunct |
michelleharrold
changed the title
Provide reformatting for the DMAP land type and any associated plots
Provide reformatting for the DMAP line type and any associated plots
Dec 2, 2024
bikegeek
moved this from 🏗 In progress
to 🔎 In review
in METplus-Analysis-6.1.0 Development
Dec 10, 2024
15 tasks
jprestop
added a commit
that referenced
this issue
Dec 11, 2024
jprestop
added a commit
that referenced
this issue
Dec 11, 2024
bikegeek
added a commit
that referenced
this issue
Dec 13, 2024
* Update version * Per dtcenter/METplus#2336, call custom GHA to trigger METplus use case tests when changes are pushed to main_vX.Y and develop branches * Update keep_all_mpr_col to keep_all_cols now that DMAP linetype is also supported * Added test for reformatting the DMAP (grid_stat) linetype for supporting scatter plots * Test config file for reformatted DMAP data used for scatter plot * Replace keep_all_mpr_cols with keep_all_cols now that DMAP linetype can be used for scatter plots, line plots, and contour plots * update keep_all_mpr_cols to keep_all_cols * update the comment * Removed debug print statements * Added test for reformatted DMAP output for line and contour plots * DMAP sample data * Add values for DMAP reformatting * Config file for testing reformatting DMAP for line and contour plot support * Example data and reformatted data for stat_name/stat_value/confidence level reformatting * Refactored version of original. Content needed for matched pair data, TCMPR data, and aggregation statistics data * Added content for ranked data values, by all common stat+linetype-specific columns. Made some edits. * New example data * Clean up formatting and wording, added content for the TCDIAG reformatting * Examples for TCDIAG reformatting * Delete METreformat/test/data/ensemble_stat/ensemble_stat_20100101_120000V.stat no longer relevant due to additional columns introduced in one of the beta releases * Updated the data to the latest version of ECNT (includes additional columns) * Accidentally removed this input file * Added DMAP support * Updated for new ensemble stat ECNT * DMAP reformatting support * change aggregation status in config file * Update the ECNT/ensemble stat tests with latest data and make testing less reliant on hard-coding. * Add better explanation for the input_stats_aggregated setting * update counts for the ensemble stat data directory data: orank from 1426 to 1921 in new data, phist 18 from 9. * updated values for line_data_phist_bin from 180 to 340 and line_data_rhist_rank from 84 to 102 * Delete METreformat/test/data/ensemble_stat/ensemble_stat_20100101_120000V.stat no longer valid/out of date * fix numbe of line_data_phist_bin to 360 * update line_data_rhist_rank * Update ECNT aggregation reformatting test to not use hard-coded values * Remove use of named tuple now that test has been simplified * update the yaml file to use keep_all_cols and updated DMAP line type support in comment * Added reformatting information for ECNT * Example reformatted output for ECNT * Cleaned up format in 6.3.1 for easier reading. * Update docs/Users_Guide/reformat_stat_data.rst use suggested text Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst use suggested reformatting Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst use suggested formatting Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst use suggested reformatting Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst use suggested format Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst use suggested format/reformatting Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested formatting Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested formatting Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested fix Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested fix Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested fix Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested fix Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested fix Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested fix Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst applying suggested change Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update reformat_stat_data.rst updated MET tool names from lower case to camel case with '-' in between the two words * Update reformat_stat_data.rst Replace text version of table references to links to the MET User's Guide * Address duplicate explicit target name in links for table 11.1, 12.1, and 13.1 * Capitalizing MET tool names * Per #348, updated spacing to attempt to fix formatting and update capitalization of MET tools * Per #348, updated spacing to attempt to fix formatting and update capitalization of MET tools * Per #348, removing additional space before literal include directive so it will render correctly in RTD * Per #348, removing additional space before literal include directive so it will render correctly in RTD * Per #348, adjusting alignment for appropriate alignment in rendering * Per #348, modified spacing and capitalization * Fixed some ambiguous text that was meant to be removed or reworded from the previous version of documentation --------- Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
bikegeek
added a commit
that referenced
this issue
Dec 13, 2024
* Update version * Per dtcenter/METplus#2336, call custom GHA to trigger METplus use case tests when changes are pushed to main_vX.Y and develop branches * Update keep_all_mpr_col to keep_all_cols now that DMAP linetype is also supported * Added test for reformatting the DMAP (grid_stat) linetype for supporting scatter plots * Test config file for reformatted DMAP data used for scatter plot * Replace keep_all_mpr_cols with keep_all_cols now that DMAP linetype can be used for scatter plots, line plots, and contour plots * update keep_all_mpr_cols to keep_all_cols * update the comment * Removed debug print statements * Added test for reformatted DMAP output for line and contour plots * DMAP sample data * Add values for DMAP reformatting * Config file for testing reformatting DMAP for line and contour plot support * Example data and reformatted data for stat_name/stat_value/confidence level reformatting * Refactored version of original. Content needed for matched pair data, TCMPR data, and aggregation statistics data * Added content for ranked data values, by all common stat+linetype-specific columns. Made some edits. * New example data * Clean up formatting and wording, added content for the TCDIAG reformatting * Examples for TCDIAG reformatting * Delete METreformat/test/data/ensemble_stat/ensemble_stat_20100101_120000V.stat no longer relevant due to additional columns introduced in one of the beta releases * Updated the data to the latest version of ECNT (includes additional columns) * Accidentally removed this input file * Added DMAP support * Updated for new ensemble stat ECNT * DMAP reformatting support * change aggregation status in config file * Update the ECNT/ensemble stat tests with latest data and make testing less reliant on hard-coding. * Add better explanation for the input_stats_aggregated setting * update counts for the ensemble stat data directory data: orank from 1426 to 1921 in new data, phist 18 from 9. * updated values for line_data_phist_bin from 180 to 340 and line_data_rhist_rank from 84 to 102 * Delete METreformat/test/data/ensemble_stat/ensemble_stat_20100101_120000V.stat no longer valid/out of date * fix numbe of line_data_phist_bin to 360 * update line_data_rhist_rank * Update ECNT aggregation reformatting test to not use hard-coded values * Remove use of named tuple now that test has been simplified * update the yaml file to use keep_all_cols and updated DMAP line type support in comment * Added reformatting information for ECNT * Example reformatted output for ECNT * Cleaned up format in 6.3.1 for easier reading. * Update docs/Users_Guide/reformat_stat_data.rst use suggested text Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst use suggested reformatting Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst use suggested formatting Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst use suggested reformatting Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst use suggested format Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst use suggested format/reformatting Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested formatting Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested formatting Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested fix Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested fix Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested fix Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested fix Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested fix Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested fix Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst apply suggested Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst applying suggested change Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/reformat_stat_data.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update reformat_stat_data.rst updated MET tool names from lower case to camel case with '-' in between the two words * Update reformat_stat_data.rst Replace text version of table references to links to the MET User's Guide * Address duplicate explicit target name in links for table 11.1, 12.1, and 13.1 * Capitalizing MET tool names * Per #348, updated spacing to attempt to fix formatting and update capitalization of MET tools * Per #348, updated spacing to attempt to fix formatting and update capitalization of MET tools * Per #348, removing additional space before literal include directive so it will render correctly in RTD * Per #348, removing additional space before literal include directive so it will render correctly in RTD * Per #348, adjusting alignment for appropriate alignment in rendering * Per #348, modified spacing and capitalization * Fixed some ambiguous text that was meant to be removed or reworded from the previous version of documentation --------- Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: METdataio
METdataio: General
priority: high
High Priority
reporting: NRL METplus
Naval Research Laboratory METplus Project
requestor: Navy/NRL
Naval Research Laboratory
type: enhancement
Improve something that it is currently doing
Describe the Enhancement
In order to support NRL's need for command line plotting,
provide a reformatter for DMAP linetype from the MET GridStat tool output. Consider whether any further processing is required, i.e. running METcalcpy agg_stat.py to calculate aggregation statistics. Consider what plot types might be useful and ensure that the reformatter is supporting formats for these plot types.
Time Estimate
Estimate the amount of work required here. 3-5 days
Sub-Issues
Consider breaking the enhancement down into sub-issues.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
7730022
Define the Metadata
Assignee
Labels
Milestone and Projects
Define Related Issue(s)
Consider the impact to the other METplus components.
Enhancement Checklist
See the METplus Workflow for details.
Branch name:
feature_<Issue Number>_<Description>
Pull request:
feature <Issue Number> <Description>
Select: Reviewer(s) and Development issue
Select: Milestone as the next official version
Select: METdataio-X.Y.Z Development project for development toward the next official release
The text was updated successfully, but these errors were encountered: