Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 238 headers #239

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Feature 238 headers #239

merged 4 commits into from
Oct 18, 2023

Conversation

lisagoodrich
Copy link
Contributor

@lisagoodrich lisagoodrich commented Oct 18, 2023

Pull Request Testing

  • Describe testing already performed for these changes:

  • I have reviewed all of the User's Guide files including the index.rst files and updated to the correct header formatting.

  • I also capitalized some of the headers to match formatting across the documentation.

  • I compared the develop web pages to the feature_238_headers web pages all of the headers are in the correct position. The index and Chapters 1-6 were reviewed.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
    Please review for any inconsistencies or details that I might have missed. Were there any other documentation sections?

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No, there are no errors]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by 10/27/23.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lisagoodrich I reviewed all of the User's Guide files both in the "Files Changed" area of this PR and in RTD. Thanks for those additional capitalization fixes and for all of your work on this task. I have ensured that all tests passed. I approve this PR.

@jprestop
Copy link
Collaborator

@lisagoodrich Please merge the pull request, delete your branch, and close the sub-task issue when you can.

@lisagoodrich
Copy link
Contributor Author

@jprestop I do not have permission to merge in the changes on this branch. Is this something @bikegeek could do?

@jprestop
Copy link
Collaborator

It's ok @lisagoodrich. I can take care of it.

@jprestop jprestop merged commit e21ea18 into develop Oct 18, 2023
@jprestop jprestop deleted the feature_238_headers branch October 18, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Documentation: Make Headers Consistent in All METdataio Guides
2 participants